From: Alex Dewar <alex.dewar90@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Alex Dewar <alex.dewar90@gmail.com>,
Evgeniy Polyakov <zbr@ioremap.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] w1: Remove pointless debug code
Date: Wed, 9 Sep 2020 20:41:32 +0100 [thread overview]
Message-ID: <20200909194132.212925-1-alex.dewar90@gmail.com> (raw)
It doesn't seem obvious why zeroing sl before freeing it would help with
debugging, so just remove this code.
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
drivers/w1/w1.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 4f597b0fd1da..02a0e66144a4 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -801,9 +801,6 @@ int w1_unref_slave(struct w1_slave *sl)
w1_family_notify(BUS_NOTIFY_DEL_DEVICE, sl);
device_unregister(&sl->dev);
- #ifdef DEBUG
- memset(sl, 0, sizeof(*sl));
- #endif
kfree(sl);
}
atomic_dec(&dev->refcnt);
--
2.28.0
reply other threads:[~2020-09-09 19:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909194132.212925-1-alex.dewar90@gmail.com \
--to=alex.dewar90@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).