From: Kees Cook <keescook@chromium.org>
To: kernel-hardening@lists.openwall.com
Cc: Kees Cook <keescook@chromium.org>, John Wood <john.wood@gmx.com>,
Matthew Wilcox <willy@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Iurii Zaikin <yzaikin@google.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: [RFC PATCH 5/6] security/fbfam: Detect a fork brute force attack
Date: Thu, 10 Sep 2020 13:21:06 -0700 [thread overview]
Message-ID: <20200910202107.3799376-6-keescook@chromium.org> (raw)
In-Reply-To: <20200910202107.3799376-1-keescook@chromium.org>
From: John Wood <john.wood@gmx.com>
To detect a fork brute force attack it is necessary to compute the
crashing rate of the application. This calculation is performed in each
fatal fail of a task, or in other words, when a core dump is triggered.
If this rate shows that the application is crashing quickly, there is a
clear signal that an attack is happening.
Since the crashing rate is computed in milliseconds per fault, if this
rate goes under a certain threshold a warning is triggered.
Signed-off-by: John Wood <john.wood@gmx.com>
---
fs/coredump.c | 2 ++
include/fbfam/fbfam.h | 2 ++
security/fbfam/fbfam.c | 39 +++++++++++++++++++++++++++++++++++++++
3 files changed, 43 insertions(+)
diff --git a/fs/coredump.c b/fs/coredump.c
index 76e7c10edfc0..d4ba4e1828d5 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -51,6 +51,7 @@
#include "internal.h"
#include <trace/events/sched.h>
+#include <fbfam/fbfam.h>
int core_uses_pid;
unsigned int core_pipe_limit;
@@ -825,6 +826,7 @@ void do_coredump(const kernel_siginfo_t *siginfo)
fail_creds:
put_cred(cred);
fail:
+ fbfam_handle_attack(siginfo->si_signo);
return;
}
diff --git a/include/fbfam/fbfam.h b/include/fbfam/fbfam.h
index 2cfe51d2b0d5..9ac8e33d8291 100644
--- a/include/fbfam/fbfam.h
+++ b/include/fbfam/fbfam.h
@@ -12,10 +12,12 @@ extern struct ctl_table fbfam_sysctls[];
int fbfam_fork(struct task_struct *child);
int fbfam_execve(void);
int fbfam_exit(void);
+int fbfam_handle_attack(int signal);
#else
static inline int fbfam_fork(struct task_struct *child) { return 0; }
static inline int fbfam_execve(void) { return 0; }
static inline int fbfam_exit(void) { return 0; }
+static inline int fbfam_handle_attack(int signal) { return 0; }
#endif
#endif /* _FBFAM_H_ */
diff --git a/security/fbfam/fbfam.c b/security/fbfam/fbfam.c
index 9be4639b72eb..3aa669e4ea51 100644
--- a/security/fbfam/fbfam.c
+++ b/security/fbfam/fbfam.c
@@ -4,7 +4,9 @@
#include <linux/errno.h>
#include <linux/gfp.h>
#include <linux/jiffies.h>
+#include <linux/printk.h>
#include <linux/refcount.h>
+#include <linux/signal.h>
#include <linux/slab.h>
/**
@@ -172,3 +174,40 @@ int fbfam_exit(void)
return 0;
}
+/**
+ * fbfam_handle_attack() - Fork brute force attack detection.
+ * @signal: Signal number that causes the core dump.
+ *
+ * The crashing rate of an application is computed in milliseconds per fault in
+ * each crash. So, if this rate goes under a certain threshold there is a clear
+ * signal that the application is crashing quickly. At this moment, a fork brute
+ * force attack is happening.
+ *
+ * Return: -EFAULT if the current task doesn't have statistical data. Zero
+ * otherwise.
+ */
+int fbfam_handle_attack(int signal)
+{
+ struct fbfam_stats *stats = current->fbfam_stats;
+ u64 delta_jiffies, delta_time;
+ u64 crashing_rate;
+
+ if (!stats)
+ return -EFAULT;
+
+ if (!(signal == SIGILL || signal == SIGBUS || signal == SIGKILL ||
+ signal == SIGSEGV || signal == SIGSYS))
+ return 0;
+
+ stats->faults += 1;
+
+ delta_jiffies = get_jiffies_64() - stats->jiffies;
+ delta_time = jiffies64_to_msecs(delta_jiffies);
+ crashing_rate = delta_time / (u64)stats->faults;
+
+ if (crashing_rate < (u64)sysctl_crashing_rate_threshold)
+ pr_warn("fbfam: Fork brute force attack detected\n");
+
+ return 0;
+}
+
--
2.25.1
next prev parent reply other threads:[~2020-09-10 20:23 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 20:21 [RESEND][RFC PATCH 0/6] Fork brute force attack mitigation (fbfam) Kees Cook
2020-09-10 20:21 ` [RFC PATCH 1/6] security/fbfam: Add a Kconfig to enable the fbfam feature Kees Cook
2020-09-10 21:21 ` Jann Horn
2020-09-17 17:32 ` John Wood
2020-09-10 23:18 ` Kees Cook
2020-09-17 18:40 ` John Wood
2020-09-17 22:05 ` Kees Cook
2020-09-18 14:50 ` John Wood
2020-09-10 20:21 ` [RFC PATCH 2/6] security/fbfam: Add the api to manage statistics Kees Cook
2020-09-10 23:23 ` Kees Cook
2020-09-10 20:21 ` [RFC PATCH 3/6] security/fbfam: Use " Kees Cook
2020-09-10 20:27 ` Jann Horn
2020-09-10 23:33 ` Kees Cook
2020-09-29 23:47 ` Steven Rostedt
2020-09-29 23:49 ` Steven Rostedt
2020-10-03 9:52 ` John Wood
2020-09-10 20:21 ` [RFC PATCH 4/6] security/fbfam: Add a new sysctl to control the crashing rate threshold Kees Cook
2020-09-10 23:14 ` Kees Cook
2020-09-13 14:33 ` John Wood
2020-09-10 20:21 ` Kees Cook [this message]
2020-09-10 21:10 ` [RFC PATCH 5/6] security/fbfam: Detect a fork brute force attack Jann Horn
2020-09-13 17:54 ` John Wood
2020-09-14 19:42 ` Jann Horn
2020-09-15 18:44 ` John Wood
2020-09-10 23:49 ` Kees Cook
2020-09-11 0:01 ` Jann Horn
2020-09-13 16:56 ` John Wood
2020-09-14 19:39 ` Jann Horn
2020-09-15 17:36 ` John Wood
2020-09-10 20:21 ` [RFC PATCH 6/6] security/fbfam: Mitigate " Kees Cook
2020-09-10 20:55 ` Jann Horn
2020-09-10 23:56 ` Kees Cook
2020-09-11 0:20 ` Jann Horn
2020-09-18 16:02 ` John Wood
2020-09-18 21:35 ` Kees Cook
2020-09-19 8:01 ` John Wood
2020-09-10 20:39 ` [RESEND][RFC PATCH 0/6] Fork brute force attack mitigation (fbfam) Jann Horn
2020-09-10 23:58 ` Kees Cook
2020-09-11 14:48 ` John Wood
2020-09-12 7:55 ` Kees Cook
2020-09-12 12:24 ` John Wood
2020-09-12 0:03 ` James Morris
2020-09-12 7:56 ` Kees Cook
2020-09-12 9:36 ` John Wood
2020-09-12 14:47 ` Mel Gorman
2020-09-12 20:48 ` Ondrej Mosnacek
2020-09-13 7:24 ` John Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910202107.3799376-6-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=bsegall@google.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=jmorris@namei.org \
--cc=john.wood@gmx.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=serge@hallyn.com \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).