From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: joe@perches.com
Cc: lukas.bulwahn@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
dwaipayanray1@gmail.com, apw@canonical.com,
linux-kernel@vger.kernel.org
Subject: [PATCH] checkpatch: extend author Signed-off-by check for split From: header
Date: Sat, 19 Sep 2020 13:42:25 +0530 [thread overview]
Message-ID: <20200919081225.28624-1-dwaipayanray1@gmail.com> (raw)
Checkpatch did not handle cases where the author From: header
was split into two lines. The author string went empty and
checkpatch generated a false NO_AUTHOR_SIGN_OFF warning.
Support split From: headers in AUTHOR_SIGN_OFF check by adding
an additional clause to resolve author identity in such cases.
Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
---
scripts/checkpatch.pl | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 504d2e431c60..86975baead22 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1210,6 +1210,16 @@ sub reformat_email {
return format_email($email_name, $email_address);
}
+sub format_author_email {
+ my ($email, $from) = @_;
+
+ $email = encode("utf8", $email) if ($from =~ /=\?utf-8\?/i);
+ $email =~ s/"//g;
+ $email = reformat_email($email);
+
+ return $email;
+}
+
sub same_email_addresses {
my ($email1, $email2) = @_;
@@ -2347,6 +2357,7 @@ sub process {
my $signoff = 0;
my $author = '';
my $authorsignoff = 0;
+ my $prevheader = '';
my $is_patch = 0;
my $is_binding_patch = -1;
my $in_header_lines = $file ? 0 : 1;
@@ -2658,12 +2669,21 @@ sub process {
}
}
+# Check the patch for a split From:
+ if($prevheader ne '') {
+ if ($author eq '' && decode("MIME-Header", $prevheader) =~ /^From:\s*(.*)/) {
+ my $email = $1.$line;
+ $author = format_author_email($email, $prevheader);
+ }
+ $prevheader = '';
+ }
+
# Check the patch for a From:
if (decode("MIME-Header", $line) =~ /^From:\s*(.*)/) {
- $author = $1;
- $author = encode("utf8", $author) if ($line =~ /=\?utf-8\?/i);
- $author =~ s/"//g;
- $author = reformat_email($author);
+ $author = format_author_email($1, $line);
+ if($author eq '') {
+ $prevheader = $line;
+ }
}
# Check the patch for a signoff:
--
2.27.0
next reply other threads:[~2020-09-19 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 8:12 Dwaipayan Ray [this message]
2020-09-19 17:26 ` [PATCH] checkpatch: extend author Signed-off-by check for split From: header Joe Perches
2020-09-19 18:12 ` Lukas Bulwahn
2020-09-19 18:19 ` Joe Perches
2020-09-19 18:36 ` Lukas Bulwahn
2020-09-19 19:38 ` Dwaipayan Ray
2020-09-19 19:47 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919081225.28624-1-dwaipayanray1@gmail.com \
--to=dwaipayanray1@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).