HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons
diff mbox series

Message ID CADGsf-Gs9EM770jTVX=yABBLAT1rdfBYb5jam720yqez=D3VHg@mail.gmail.com
State New, archived
Headers show
Series
  • HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons
Related show

Commit Message

Mikael Wikström Sept. 19, 2020, 8:04 p.m. UTC
One more device that needs 40d5bb87 to resolve regression for the trackpoint
and three mouse buttons on the type cover of the Lenovo X1 Tablet Gen3.

It is probably also needed for the Lenovo X1 Tablet Gen2 with PID 0x60a3

Signed-off-by: Mikael Wikström <leakim.wikstrom@gmail.com>
---
 drivers/hid/hid-ids.h        | 1 +
 drivers/hid/hid-multitouch.c | 6 ++++++
 2 files changed, 7 insertions(+)

Comments

Jiri Kosina Sept. 22, 2020, 9:16 a.m. UTC | #1
On Sat, 19 Sep 2020, Mikael Wikström wrote:

> One more device that needs 40d5bb87 to resolve regression for the trackpoint
> and three mouse buttons on the type cover of the Lenovo X1 Tablet Gen3.
> 
> It is probably also needed for the Lenovo X1 Tablet Gen2 with PID 0x60a3
> 
> Signed-off-by: Mikael Wikström <leakim.wikstrom@gmail.com>

Thanks for the patch. Unfortunately it has been whitespace damaged by your 
client. Could you please fix that up (some help might be found in [1]) and 
resubmit?

Thanks.

[1] Documentation/process/email-clients.rst

Patch
diff mbox series

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 74fc1df6e3c2..6a6e2c1b6090 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -727,6 +727,7 @@ 
 #define USB_DEVICE_ID_LENOVO_TP10UBKBD 0x6062
 #define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067
 #define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
+#define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
 #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d
 #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019 0x6019
 #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_602E 0x602e
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index e3152155c4b8..99f041afd5c0 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1973,6 +1973,12 @@  static const struct hid_device_id mt_devices[] = {
  HID_DEVICE(BUS_I2C, HID_GROUP_GENERIC,
  USB_VENDOR_ID_LG, I2C_DEVICE_ID_LG_7010) },

+ /* Lenovo X1 TAB Gen 3 */
+ { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
+ HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
+    USB_VENDOR_ID_LENOVO,
+    USB_DEVICE_ID_LENOVO_X1_TAB3) },
+
  /* MosArt panels */
  { .driver_data = MT_CLS_CONFIDENCE_MINUS_ONE,
  MT_USB_DEVICE(USB_VENDOR_ID_ASUS,