From: sathyanarayanan.kuppuswamy@linux.intel.com To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: [PATCH v9 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic Date: Tue, 22 Sep 2020 13:54:31 -0700 [thread overview] Message-ID: <e4f72276c8bd363a97b747f4a806c27fcf49ca28.1600457297.git.sathyanarayanan.kuppuswamy@linux.intel.com> (raw) In-Reply-To: <cover.1600457297.git.sathyanarayanan.kuppuswamy@linux.intel.com> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> In DPC service enable logic, check for services & PCIE_PORT_SERVICE_AER implies pci_aer_available() is true. So there is no need to explicitly check it again. Also, passing pcie_ports=dpc-native in kernel command line implies DPC needs to be enabled in native mode irrespective of AER ownership status. So checking for pci_aer_available() without checking for pcie_ports status is incorrect. Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> --- drivers/pci/pcie/portdrv_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c index 2c0278f0fdcc..e257a2ca3595 100644 --- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -252,7 +252,6 @@ static int get_port_device_capability(struct pci_dev *dev) * permission to use AER. */ if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && - pci_aer_available() && (host->native_dpc || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.nkuppuswamy@gmail.com> To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: [PATCH v9 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic Date: Sun, 27 Sep 2020 18:11:35 -0700 [thread overview] Message-ID: <e4f72276c8bd363a97b747f4a806c27fcf49ca28.1600457297.git.sathyanarayanan.kuppuswamy@linux.intel.com> (raw) Message-ID: <20200928011135.65KtxbVmq5YnsAFi2qOcXQ2RGm6P8oJuV0kYQrn4iaM@z> (raw) In-Reply-To: <cover.1600457297.git.sathyanarayanan.kuppuswamy@linux.intel.com> In-Reply-To: <cover.1600457297.git.sathyanarayanan.kuppuswamy@linux.intel.com> In DPC service enable logic, check for services & PCIE_PORT_SERVICE_AER implies pci_aer_available() is true. So there is no need to explicitly check it again. Also, passing pcie_ports=dpc-native in kernel command line implies DPC needs to be enabled in native mode irrespective of AER ownership status. So checking for pci_aer_available() without checking for pcie_ports status is incorrect. Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> --- drivers/pci/pcie/portdrv_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c index 2c0278f0fdcc..e257a2ca3595 100644 --- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -252,7 +252,6 @@ static int get_port_device_capability(struct pci_dev *dev) * permission to use AER. */ if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && - pci_aer_available() && (host->native_dpc || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC; -- 2.17.1
next prev parent reply other threads:[~2020-09-22 20:59 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-22 20:54 [PATCH v9 0/5] Simplify PCIe native ownership detection logic sathyanarayanan.kuppuswamy 2020-09-18 19:58 ` [PATCH v9 1/5] PCI: Conditionally initialize host bridge native_* members sathyanarayanan.kuppuswamy 2020-09-22 20:39 ` Bjorn Helgaas 2020-09-22 20:50 ` Kuppuswamy, Sathyanarayanan 2020-09-22 20:56 ` Bjorn Helgaas 2020-09-22 20:54 ` sathyanarayanan.kuppuswamy 2020-09-28 1:11 ` Kuppuswamy Sathyanarayanan 2020-09-18 19:58 ` [PATCH v9 3/5] ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set sathyanarayanan.kuppuswamy 2020-09-22 20:54 ` sathyanarayanan.kuppuswamy 2020-09-28 1:11 ` Kuppuswamy Sathyanarayanan 2020-09-18 19:58 ` [PATCH v9 5/5] PCI/DPC: Move AER/DPC dependency checks out of DPC driver sathyanarayanan.kuppuswamy 2020-09-22 20:54 ` sathyanarayanan.kuppuswamy 2020-09-28 1:11 ` Kuppuswamy Sathyanarayanan 2020-09-22 20:54 ` sathyanarayanan.kuppuswamy [this message] 2020-09-28 1:11 ` [PATCH v9 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic Kuppuswamy Sathyanarayanan 2020-09-28 1:11 ` [PATCH v9 0/5] Simplify PCIe native ownership detection logic Kuppuswamy Sathyanarayanan 2020-09-28 1:11 ` [PATCH v9 2/5] ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set Kuppuswamy Sathyanarayanan 2020-09-29 20:58 ` [PATCH v9 0/5] Simplify PCIe native ownership detection logic Kuppuswamy, Sathyanarayanan 2020-09-29 21:04 ` Bjorn Helgaas 2020-09-29 21:23 ` Kuppuswamy, Sathyanarayanan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e4f72276c8bd363a97b747f4a806c27fcf49ca28.1600457297.git.sathyanarayanan.kuppuswamy@linux.intel.com \ --to=sathyanarayanan.kuppuswamy@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=bhelgaas@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).