[1/3] dt-bindings: watchdog: fsl-imx: document i.MX compatibles
diff mbox series

Message ID 20200926162302.32525-1-krzk@kernel.org
State New, archived
Headers show
Series
  • [1/3] dt-bindings: watchdog: fsl-imx: document i.MX compatibles
Related show

Commit Message

Krzysztof Kozlowski Sept. 26, 2020, 4:23 p.m. UTC
Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles used in DTSes (even
though driver binds only to fsl,imx21-wdt) to fix dtbs_check warnings
like:

  arch/arm/boot/dts/imx53-qsb.dt.yaml: gpio@53fe0000: compatible:
    ['fsl,imx53-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Rob Herring Sept. 29, 2020, 7:13 p.m. UTC | #1
On Sat, 26 Sep 2020 18:23:00 +0200, Krzysztof Kozlowski wrote:
> Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles used in DTSes (even
> though driver binds only to fsl,imx21-wdt) to fix dtbs_check warnings
> like:
> 
>   arch/arm/boot/dts/imx53-qsb.dt.yaml: gpio@53fe0000: compatible:
>     ['fsl,imx53-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Shawn Guo Oct. 29, 2020, 2:35 p.m. UTC | #2
On Sat, Sep 26, 2020 at 06:23:00PM +0200, Krzysztof Kozlowski wrote:
> Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles used in DTSes (even
> though driver binds only to fsl,imx21-wdt) to fix dtbs_check warnings
> like:
> 
>   arch/arm/boot/dts/imx53-qsb.dt.yaml: gpio@53fe0000: compatible:
>     ['fsl,imx53-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index 991b4e33486e..a06e70f44fd0 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -18,10 +18,24 @@ properties:
>        - const: fsl,imx21-wdt
>        - items:
>            - enum:
> +              - fsl,imx25-wdt
> +              - fsl,imx27-wdt
> +              - fsl,imx31-wdt
> +              - fsl,imx35-wdt
> +              - fsl,imx50-wdt
> +              - fsl,imx51-wdt
> +              - fsl,imx53-wdt
> +              - fsl,imx6q-wdt
> +              - fsl,imx6sl-wdt
> +              - fsl,imx6sll-wdt
> +              - fsl,imx6sx-wdt
> +              - fsl,imx6ul-wdt
> +              - fsl,imx7d-wdt
>                - fsl,imx8mm-wdt
>                - fsl,imx8mn-wdt
>                - fsl,imx8mp-wdt
>                - fsl,imx8mq-wdt

Could you add the following two as well?

    - fsl,ls1012a-wdt
    - fsl,ls1043a-wdt

Shawn

> +              - fsl,vf610-wdt
>            - const: fsl,imx21-wdt
>  
>    reg:
> -- 
> 2.17.1
>
Krzysztof Kozlowski Oct. 29, 2020, 4:13 p.m. UTC | #3
On Thu, Oct 29, 2020 at 10:35:09PM +0800, Shawn Guo wrote:
> On Sat, Sep 26, 2020 at 06:23:00PM +0200, Krzysztof Kozlowski wrote:
> > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles used in DTSes (even
> > though driver binds only to fsl,imx21-wdt) to fix dtbs_check warnings
> > like:
> > 
> >   arch/arm/boot/dts/imx53-qsb.dt.yaml: gpio@53fe0000: compatible:
> >     ['fsl,imx53-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml  | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > index 991b4e33486e..a06e70f44fd0 100644
> > --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > @@ -18,10 +18,24 @@ properties:
> >        - const: fsl,imx21-wdt
> >        - items:
> >            - enum:
> > +              - fsl,imx25-wdt
> > +              - fsl,imx27-wdt
> > +              - fsl,imx31-wdt
> > +              - fsl,imx35-wdt
> > +              - fsl,imx50-wdt
> > +              - fsl,imx51-wdt
> > +              - fsl,imx53-wdt
> > +              - fsl,imx6q-wdt
> > +              - fsl,imx6sl-wdt
> > +              - fsl,imx6sll-wdt
> > +              - fsl,imx6sx-wdt
> > +              - fsl,imx6ul-wdt
> > +              - fsl,imx7d-wdt
> >                - fsl,imx8mm-wdt
> >                - fsl,imx8mn-wdt
> >                - fsl,imx8mp-wdt
> >                - fsl,imx8mq-wdt
> 
> Could you add the following two as well?
> 
>     - fsl,ls1012a-wdt
>     - fsl,ls1043a-wdt

I focused in these patches on i.MX but I can fix the Layerscape as well.

Best regards,
Krzysztof

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 991b4e33486e..a06e70f44fd0 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -18,10 +18,24 @@  properties:
       - const: fsl,imx21-wdt
       - items:
           - enum:
+              - fsl,imx25-wdt
+              - fsl,imx27-wdt
+              - fsl,imx31-wdt
+              - fsl,imx35-wdt
+              - fsl,imx50-wdt
+              - fsl,imx51-wdt
+              - fsl,imx53-wdt
+              - fsl,imx6q-wdt
+              - fsl,imx6sl-wdt
+              - fsl,imx6sll-wdt
+              - fsl,imx6sx-wdt
+              - fsl,imx6ul-wdt
+              - fsl,imx7d-wdt
               - fsl,imx8mm-wdt
               - fsl,imx8mn-wdt
               - fsl,imx8mp-wdt
               - fsl,imx8mq-wdt
+              - fsl,vf610-wdt
           - const: fsl,imx21-wdt
 
   reg: