[5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up
diff mbox series

Message ID 20200927165947.7317-5-krzk@kernel.org
State New, archived
Headers show
Series
  • [1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up
Related show

Commit Message

Krzysztof Kozlowski Sept. 27, 2020, 4:59 p.m. UTC
The PMIC's interrupt is level low and should be pulled up.  The PMIC's
device node had pinctrl-0 property but it lacked pinctrl-names which
is required to apply the pin configuration.

Fixes: 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
Fixes: 3e44dd09736d ("arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC support")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Chen Sept. 28, 2020, 12:08 a.m. UTC | #1
Add Robin Gong.

> Subject: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's
> interrupt line pull-up
> 
> The PMIC's interrupt is level low and should be pulled up.  The PMIC's device
> node had pinctrl-0 property but it lacked pinctrl-names which is required to
> apply the pin configuration.
> 
> Fixes: 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
> Fixes: 3e44dd09736d ("arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC
> support")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> index 46e76cf32b2f..7dfee715a2c4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> @@ -53,6 +53,7 @@
>  	pmic@4b {
>  		compatible = "rohm,bd71847";
>  		reg = <0x4b>;
> +		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_pmic>;
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1

Peter

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index 46e76cf32b2f..7dfee715a2c4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -53,6 +53,7 @@ 
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;