rcu-tasks: Add missing inline to show_rcu_tasks_rude_gp_kthread() dummy
diff mbox series

Message ID 20201016103144.23491-1-geert@linux-m68k.org
State New, archived
Headers show
Series
  • rcu-tasks: Add missing inline to show_rcu_tasks_rude_gp_kthread() dummy
Related show

Commit Message

Geert Uytterhoeven Oct. 16, 2020, 10:31 a.m. UTC
If CONFIG_TINY_RCU=y:

    In file included from kernel/rcu/update.c:591:
    kernel/rcu/tasks.h:710:13: warning: ‘show_rcu_tasks_rude_gp_kthread’ defined but not used [-Wunused-function]
     static void show_rcu_tasks_rude_gp_kthread(void) {}
		 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fix this by marking show_rcu_tasks_rude_gp_kthread() inline.

Fixes: e21408ceec2de5be ("rcu-tasks: Add RCU tasks to rcutorture writer stall output")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Exposed by commit 1e6c62a882155772 ("bpf: Introduce sleepable BPF
programs"), which selects TASKS_TRACE_RCU.
---
 kernel/rcu/tasks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul E. McKenney Oct. 17, 2020, 3:38 p.m. UTC | #1
On Fri, Oct 16, 2020 at 12:31:44PM +0200, Geert Uytterhoeven wrote:
> If CONFIG_TINY_RCU=y:
> 
>     In file included from kernel/rcu/update.c:591:
>     kernel/rcu/tasks.h:710:13: warning: ‘show_rcu_tasks_rude_gp_kthread’ defined but not used [-Wunused-function]
>      static void show_rcu_tasks_rude_gp_kthread(void) {}
> 		 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fix this by marking show_rcu_tasks_rude_gp_kthread() inline.
> 
> Fixes: e21408ceec2de5be ("rcu-tasks: Add RCU tasks to rcutorture writer stall output")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Good catch, but commit 2cf0c4b5 ("rcutorture: Make grace-period kthread
report match RCU flavor being tested") beat you to it, though apparently
by accident.

Either way, thank you for your time and attention!

							Thanx, Paul

> ---
> Exposed by commit 1e6c62a882155772 ("bpf: Introduce sleepable BPF
> programs"), which selects TASKS_TRACE_RCU.
> ---
>  kernel/rcu/tasks.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index d5d9f2d03e8a0ac9..8c290cc45e6fc63a 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -707,7 +707,7 @@ static void show_rcu_tasks_rude_gp_kthread(void)
>  #endif /* #ifndef CONFIG_TINY_RCU */
>  
>  #else /* #ifdef CONFIG_TASKS_RUDE_RCU */
> -static void show_rcu_tasks_rude_gp_kthread(void) {}
> +static inline void show_rcu_tasks_rude_gp_kthread(void) {}
>  #endif /* #else #ifdef CONFIG_TASKS_RUDE_RCU */
>  
>  ////////////////////////////////////////////////////////////////////////
> -- 
> 2.17.1
>

Patch
diff mbox series

diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index d5d9f2d03e8a0ac9..8c290cc45e6fc63a 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -707,7 +707,7 @@  static void show_rcu_tasks_rude_gp_kthread(void)
 #endif /* #ifndef CONFIG_TINY_RCU */
 
 #else /* #ifdef CONFIG_TASKS_RUDE_RCU */
-static void show_rcu_tasks_rude_gp_kthread(void) {}
+static inline void show_rcu_tasks_rude_gp_kthread(void) {}
 #endif /* #else #ifdef CONFIG_TASKS_RUDE_RCU */
 
 ////////////////////////////////////////////////////////////////////////