arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value
diff mbox series

Message ID 20201018194225.3361182-1-fparent@baylibre.com
State Accepted
Commit e55c56df43dd11de4a6c08e3ea52ca45b51c8800
Headers show
Series
  • arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value
Related show

Commit Message

Fabien Parent Oct. 18, 2020, 7:42 p.m. UTC
The binding documentation says:
- #mbox-cells: Should be 2.
	<&phandle channel priority>
	phandle: Label name of a gce node.
	channel: Channel of mailbox. Be equal to the thread id of GCE.
	priority: Priority of GCE thread.

Fix the value of #mbox-cells.

Fixes: d3c306e31bc7 ("arm64: dts: add gce node for mt8183")
Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthias Brugger Oct. 19, 2020, 10:20 a.m. UTC | #1
On 18/10/2020 21:42, Fabien Parent wrote:
> The binding documentation says:
> - #mbox-cells: Should be 2.
> 	<&phandle channel priority>
> 	phandle: Label name of a gce node.
> 	channel: Channel of mailbox. Be equal to the thread id of GCE.
> 	priority: Priority of GCE thread.
> 
> Fix the value of #mbox-cells.
> 
> Fixes: d3c306e31bc7 ("arm64: dts: add gce node for mt8183")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Applied, to v5.10-tmp/dts64 thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 102105871db2..9a3cf95676e1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -352,7 +352,7 @@ gce: mailbox@10238000 {
>   			compatible = "mediatek,mt8183-gce";
>   			reg = <0 0x10238000 0 0x4000>;
>   			interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_LOW>;
> -			#mbox-cells = <3>;
> +			#mbox-cells = <2>;
>   			clocks = <&infracfg CLK_INFRA_GCE>;
>   			clock-names = "gce";
>   		};
>

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 102105871db2..9a3cf95676e1 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -352,7 +352,7 @@  gce: mailbox@10238000 {
 			compatible = "mediatek,mt8183-gce";
 			reg = <0 0x10238000 0 0x4000>;
 			interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_LOW>;
-			#mbox-cells = <3>;
+			#mbox-cells = <2>;
 			clocks = <&infracfg CLK_INFRA_GCE>;
 			clock-names = "gce";
 		};