[v2,2/2] ARM: dts: stm32: support child mfd cells for the stm32mp1 TAMP syscon
diff mbox series

Message ID 20201021102855.18026-2-a.fatoum@pengutronix.de
State New, archived
Headers show
Series
  • [v2,1/2] dt-bindings: arm: stm32: add simple-mfd compatible for tamp node
Related show

Commit Message

Ahmad Fatoum Oct. 21, 2020, 10:28 a.m. UTC
The stm32mp1 TAMP peripheral has 32 backup registers that survive
a warm reset. This makes them suitable for storing a reboot
mode, which the vendor's kernel tree is already doing[0].

The actual syscon-reboot-mode child node can be added by a board.dts or
fixed up by the bootloader. For the child node to be probed, the
compatible needs to include simple-mfd. The binding now specifies this,
so have the SoC dtsi adhere to it.

[0]: https://github.com/STMicroelectronics/linux/commit/2e9bfc29dd

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - Dropped simple-bus. simple-mfd is all that's needed
  - reworded commit message
---
 arch/arm/boot/dts/stm32mp151.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Torgue Nov. 17, 2020, 11:18 a.m. UTC | #1
Hi Ahmad

On 10/21/20 12:28 PM, Ahmad Fatoum wrote:
> The stm32mp1 TAMP peripheral has 32 backup registers that survive
> a warm reset. This makes them suitable for storing a reboot
> mode, which the vendor's kernel tree is already doing[0].
> 
> The actual syscon-reboot-mode child node can be added by a board.dts or
> fixed up by the bootloader. For the child node to be probed, the
> compatible needs to include simple-mfd. The binding now specifies this,
> so have the SoC dtsi adhere to it.
> 
> [0]: https://github.com/STMicroelectronics/linux/commit/2e9bfc29dd
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
>    - Dropped simple-bus. simple-mfd is all that's needed
>    - reworded commit message
> ---
>   arch/arm/boot/dts/stm32mp151.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
> index 842ecffae73a..662c2408d41b 100644
> --- a/arch/arm/boot/dts/stm32mp151.dtsi
> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
> @@ -1542,7 +1542,7 @@ i2c6: i2c@5c009000 {
>   		};
>   
>   		tamp: tamp@5c00a000 {
> -			compatible = "st,stm32-tamp", "syscon";
> +			compatible = "st,stm32-tamp", "syscon", "simple-mfd";
>   			reg = <0x5c00a000 0x400>;
>   		};
>   
> 

Series applied on stm32-next.

Regards
Alex

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index 842ecffae73a..662c2408d41b 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -1542,7 +1542,7 @@  i2c6: i2c@5c009000 {
 		};
 
 		tamp: tamp@5c00a000 {
-			compatible = "st,stm32-tamp", "syscon";
+			compatible = "st,stm32-tamp", "syscon", "simple-mfd";
 			reg = <0x5c00a000 0x400>;
 		};