From: Gao Xiang <hsiangkao@aol.com>
To: linux-erofs@lists.ozlabs.org
Cc: Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Gao Xiang <hsiangkao@redhat.com>,
stable@vger.kernel.org
Subject: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages
Date: Thu, 22 Oct 2020 22:57:21 +0800 [thread overview]
Message-ID: <20201022145724.27284-1-hsiangkao@aol.com> (raw)
In-Reply-To: 20201022145724.27284-1-hsiangkao.ref@aol.com
From: Gao Xiang <hsiangkao@redhat.com>
pcluster should be only set up for all managed pages instead of
temporary pages. Since it currently uses page->mapping to identify,
the impact is minor for now.
Fixes: 5ddcee1f3a1c ("erofs: get rid of __stagingpage_alloc helper")
Cc: <stable@vger.kernel.org> # 5.5+
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
---
fs/erofs/zdata.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 50912a5420b4..86fd3bf62af6 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -1078,8 +1078,11 @@ static struct page *pickup_page_for_submission(struct z_erofs_pcluster *pcl,
cond_resched();
goto repeat;
}
- set_page_private(page, (unsigned long)pcl);
- SetPagePrivate(page);
+
+ if (tocache) {
+ set_page_private(page, (unsigned long)pcl);
+ SetPagePrivate(page);
+ }
out: /* the only exit (for tracing and debugging) */
return page;
}
--
2.24.0
next parent reply other threads:[~2020-10-22 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201022145724.27284-1-hsiangkao.ref@aol.com>
2020-10-22 14:57 ` Gao Xiang [this message]
2020-10-22 14:57 ` [PATCH 2/4] erofs: get rid of magical Z_EROFS_MAPPING_STAGING Gao Xiang
2020-10-22 14:57 ` [PATCH 3/4] erofs: insert to managed cache after adding to pcl Gao Xiang
2020-10-22 14:57 ` [PATCH 4/4] erofs: complete a missing case for inplace I/O Gao Xiang
2020-10-30 12:20 ` [PATCH 1/4] erofs: fix setting up pcluster for temporary pages Vladimir Zapolskiy
2020-10-30 12:47 ` Gao Xiang
2020-10-30 13:32 ` Vladimir Zapolskiy
2020-10-30 14:10 ` Gao Xiang
2020-11-04 1:05 ` Chao Yu
2020-11-04 1:11 ` Gao Xiang
2020-11-04 1:44 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022145724.27284-1-hsiangkao@aol.com \
--to=hsiangkao@aol.com \
--cc=chao@kernel.org \
--cc=hsiangkao@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).