From: zhenwei pi <pizhenwei@bytedance.com>
To: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, axboe@fb.com
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
pizhenwei@bytedance.com
Subject: [PATCH v2] nvme-rdma: handle nvme completion data length
Date: Fri, 23 Oct 2020 14:59:10 +0800 [thread overview]
Message-ID: <20201023065910.1358586-1-pizhenwei@bytedance.com> (raw)
Hit a kernel warning:
refcount_t: underflow; use-after-free.
WARNING: CPU: 0 PID: 0 at lib/refcount.c:28
RIP: 0010:refcount_warn_saturate+0xd9/0xe0
Call Trace:
<IRQ>
nvme_rdma_recv_done+0xf3/0x280 [nvme_rdma]
__ib_process_cq+0x76/0x150 [ib_core]
...
The reason is that a zero bytes message received from target, and the
host side continues to process without length checking, then the
previous CQE is processed twice.
Handle data length, ignore zero bytes message, and try to recovery for
corrupted CQE case.
Thanks to Chao Leng for suggestions.
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
---
drivers/nvme/host/rdma.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 9e378d0a0c01..2ecadd309f4a 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1767,6 +1767,21 @@ static void nvme_rdma_recv_done(struct ib_cq *cq, struct ib_wc *wc)
return;
}
+ /* received data length checking */
+ if (unlikely(wc->byte_len < len)) {
+ /* zero bytes message could be ignored */
+ if (!wc->byte_len) {
+ nvme_rdma_post_recv(queue, qe);
+ return;
+ }
+
+ /* corrupted completion, try to recovry */
+ dev_err(queue->ctrl->ctrl.device,
+ "Unexpected nvme completion length(%d)\n", wc->byte_len);
+ nvme_rdma_error_recovery(queue->ctrl);
+ return;
+ }
+
ib_dma_sync_single_for_cpu(ibdev, qe->dma, len, DMA_FROM_DEVICE);
/*
* AEN requests are special as they don't time out and can
--
2.11.0
next reply other threads:[~2020-10-23 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 6:59 zhenwei pi [this message]
2020-10-23 8:45 ` [PATCH v2] nvme-rdma: handle nvme completion data length Chao Leng
2020-10-23 18:01 ` Sagi Grimberg
2020-10-24 7:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023065910.1358586-1-pizhenwei@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).