From: Douglas Anderson <dianders@chromium.org>
To: jkosina@suse.cz, benjamin.tissoires@redhat.com,
gregkh@linuxfoundation.org
Cc: andrea@borgia.bo.it, kai.heng.feng@canonical.com,
linux-input@vger.kernel.org, swboyd@chromium.org,
hdegoede@redhat.com, Douglas Anderson <dianders@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] dt-bindings: HID: i2c-hid: Label this binding as deprecated
Date: Fri, 23 Oct 2020 16:22:52 -0700 [thread overview]
Message-ID: <20201023162220.v2.1.I45b53fe84e2215946f900f5b28bab1aa9d029ac7@changeid> (raw)
As pointed out by Rob Herring [1], we should have a device-specific
compatible string. This means people shouldn't be using the
"i2c-over-hid" compatible string anymore, or at least not without a
more specific compatible string before it. Specifically:
1. For newly added devices we should just have the device-specific
device string (no "hid-over-i2c" fallback) and infer the timings
and hid-descr-addr from there.
2. If there's a need for a device tree to be backward compatible, we
should list the device-specific compatible string and add the
"hid-over-i2c" fallback and the various timings.
[1] https://lore.kernel.org/r/20201019211036.GA3595039@bogus
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v2:
- ("dt-bindings: HID: i2c-hid: Label this binding as deprecated") new in v2.
Documentation/devicetree/bindings/input/hid-over-i2c.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
index c76bafaf98d2..733a5f053280 100644
--- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt
+++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
@@ -1,5 +1,8 @@
* HID over I2C Device-Tree bindings
+WARNING: this binding is deprecated. Instead of using this, create specific
+bindings for each hid-over-i2c device.
+
HID over I2C provides support for various Human Interface Devices over the
I2C bus. These devices can be for example touchpads, keyboards, touch screens
or sensors.
--
2.29.0.rc1.297.gfa9743e501-goog
next reply other threads:[~2020-10-23 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 23:22 Douglas Anderson [this message]
2020-10-23 23:22 ` [PATCH v2 2/3] dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Douglas Anderson
2020-10-23 23:30 ` Doug Anderson
2020-10-30 10:52 ` Benjamin Tissoires
2020-10-23 23:22 ` [PATCH v2 3/3] HID: i2c-hid: Support the Goodix GT7375P touchscreen Douglas Anderson
2020-10-30 11:01 ` Benjamin Tissoires
2020-10-30 10:51 ` [PATCH v2 1/3] dt-bindings: HID: i2c-hid: Label this binding as deprecated Benjamin Tissoires
2020-10-30 18:00 ` Rob Herring
2020-10-30 19:12 ` Benjamin Tissoires
2020-10-30 20:11 ` Dmitry Torokhov
2020-11-03 0:18 ` Doug Anderson
2020-10-30 16:47 ` Rob Herring
2020-11-03 0:16 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023162220.v2.1.I45b53fe84e2215946f900f5b28bab1aa9d029ac7@changeid \
--to=dianders@chromium.org \
--cc=andrea@borgia.bo.it \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jkosina@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).