From: Douglas Anderson <dianders@chromium.org>
To: jkosina@suse.cz, benjamin.tissoires@redhat.com,
gregkh@linuxfoundation.org
Cc: andrea@borgia.bo.it, kai.heng.feng@canonical.com,
linux-input@vger.kernel.org, swboyd@chromium.org,
hdegoede@redhat.com, Douglas Anderson <dianders@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/3] dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P
Date: Fri, 23 Oct 2020 16:22:53 -0700 [thread overview]
Message-ID: <20201023162220.v2.2.Ibb28033c81d87fcc13a6ba28c6ea7ac154d65f93@changeid> (raw)
In-Reply-To: <20201023162220.v2.1.I45b53fe84e2215946f900f5b28bab1aa9d029ac7@changeid>
This adds new bindings for the Goodix GT7375P touchscreen. While this
touchscreen works with generic "i2c-over-hid", the current advice is
to give it its own compatible string. The cleanest way to do this is
to give it its own bindings.
Among other things, this has the advantage that we can list the two
possible i2c addresses for this device, which gives extra checking.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v2:
- ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2.
.../bindings/input/goodix,gt7375p.yaml | 64 +++++++++++++++++++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
new file mode 100644
index 000000000000..b5008f89e26c
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Goodix GT7375P touchscreen
+
+maintainers:
+ - Benjamin Tissoires <benjamin.tissoires@redhat.com>
+ - Douglas Anderson <dianders@chromium.org>
+
+description:
+ Supports the Goodix GT7375P touchscreen.
+
+properties:
+ compatible:
+ items:
+ - const: goodix,gt7375p
+
+ reg:
+ enum:
+ - 0x5d
+ - 0x14
+
+ interrupts:
+ maxItems: 1
+
+ reset-gpios:
+ true
+
+ vdd-supply:
+ description: The 3.3V supply to the touchscreen.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - reset-gpios
+ - vdd-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,rpmh.h>
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ap_ts: touchscreen@5d {
+ compatible = "hid-over-i2c";
+ reg = <0x5d>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
+
+ reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&pp3300_ts>;
+ };
+ };
--
2.29.0.rc1.297.gfa9743e501-goog
next prev parent reply other threads:[~2020-10-23 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 23:22 [PATCH v2 1/3] dt-bindings: HID: i2c-hid: Label this binding as deprecated Douglas Anderson
2020-10-23 23:22 ` Douglas Anderson [this message]
2020-10-23 23:30 ` [PATCH v2 2/3] dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Doug Anderson
2020-10-30 10:52 ` Benjamin Tissoires
2020-10-23 23:22 ` [PATCH v2 3/3] HID: i2c-hid: Support the Goodix GT7375P touchscreen Douglas Anderson
2020-10-30 11:01 ` Benjamin Tissoires
2020-10-30 10:51 ` [PATCH v2 1/3] dt-bindings: HID: i2c-hid: Label this binding as deprecated Benjamin Tissoires
2020-10-30 18:00 ` Rob Herring
2020-10-30 19:12 ` Benjamin Tissoires
2020-10-30 20:11 ` Dmitry Torokhov
2020-11-03 0:18 ` Doug Anderson
2020-10-30 16:47 ` Rob Herring
2020-11-03 0:16 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023162220.v2.2.Ibb28033c81d87fcc13a6ba28c6ea7ac154d65f93@changeid \
--to=dianders@chromium.org \
--cc=andrea@borgia.bo.it \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jkosina@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).