From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: David Airlie <airlied@linux.ie>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-safety@lists.elisa.tech,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH] agp: amd64: remove unneeded initialization
Date: Wed, 28 Oct 2020 14:31:06 +0100 [thread overview]
Message-ID: <20201028133106.5420-1-lukas.bulwahn@gmail.com> (raw)
make clang-analyzer on x86_64 defconfig caught my attention with:
drivers/char/agp/amd64-agp.c:336:2: warning: \
Value stored to 'i' is never read [clang-analyzer-deadcode.DeadStores]
i = 0;
^
Remove this unneeded initialization to make clang-analyzer happy.
Commit a32073bffc65 ("x86_64: Clean and enhance up K8 northbridge access
code") refactored cache_nbs() and introduced this unneeded dead-store
initialization.
As compilers will detect this unneeded assignment and optimize this anyway,
the resulting binary is identical before and after this change.
No functional change. No change in binary code.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
applies cleanly on current master and next-20201028
David, please pick this minor non-urgent clean-up patch.
drivers/char/agp/amd64-agp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index b40edae32817..0413b3136541 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)
if (!amd_nb_has_feature(AMD_NB_GART))
return -ENODEV;
- i = 0;
for (i = 0; i < amd_nb_num(); i++) {
struct pci_dev *dev = node_to_amd_nb(i)->misc;
if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
--
2.17.1
next reply other threads:[~2020-10-29 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 13:31 Lukas Bulwahn [this message]
2020-10-28 14:02 ` [PATCH] agp: amd64: remove unneeded initialization Tom Rix
2020-10-29 2:37 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028133106.5420-1-lukas.bulwahn@gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=airlied@linux.ie \
--cc=clang-built-linux@googlegroups.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).