From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Olsa <jolsa@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: [RFC][PATCH 2/2] ftrace: Test arguments by adding trace_printk in function tracer
Date: Wed, 28 Oct 2020 09:15:44 -0400 [thread overview]
Message-ID: <20201028131909.923504298@goodmis.org> (raw)
In-Reply-To: 20201028131542.963014814@goodmis.org
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace_functions.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
index 89c414ce1388..4bd3194540f1 100644
--- a/kernel/trace/trace_functions.c
+++ b/kernel/trace/trace_functions.c
@@ -129,7 +129,7 @@ static void function_trace_start(struct trace_array *tr)
static void
function_trace_call(unsigned long ip, unsigned long parent_ip,
- struct ftrace_ops *op, struct pt_regs *pt_regs)
+ struct ftrace_ops *op, struct pt_regs *regs)
{
struct trace_array *tr = op->private;
struct trace_array_cpu *data;
@@ -153,6 +153,17 @@ function_trace_call(unsigned long ip, unsigned long parent_ip,
if (!atomic_read(&data->disabled)) {
local_save_flags(flags);
trace_function(tr, ip, parent_ip, flags, pc);
+#ifdef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS
+ trace_printk("%pS %lx %lx %lx %lx %lx %lx %lx\n",
+ (void *)ip,
+ kernel_stack_pointer(regs),
+ regs_get_kernel_argument(regs, 0),
+ regs_get_kernel_argument(regs, 1),
+ regs_get_kernel_argument(regs, 2),
+ regs_get_kernel_argument(regs, 3),
+ regs_get_kernel_argument(regs, 4),
+ regs_get_kernel_argument(regs, 5));
+#endif
}
ftrace_test_recursion_unlock(bit);
preempt_enable_notrace();
--
2.28.0
next prev parent reply other threads:[~2020-10-29 0:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 13:15 [RFC][PATCH 0/2] ftrace: Add access to function arguments for all callbacks Steven Rostedt
2020-10-28 13:15 ` [RFC][PATCH 1/2] ftrace/x86: Allow for arguments to be passed in to REGS by default Steven Rostedt
2020-10-28 14:25 ` [RFC][PATCH 1/2 v2] " Steven Rostedt
2020-10-28 15:29 ` Steven Rostedt
2020-10-28 20:36 ` Steven Rostedt
2020-10-28 21:14 ` Steven Rostedt
2020-10-29 8:07 ` Masami Hiramatsu
2020-10-28 13:15 ` Steven Rostedt [this message]
2020-10-28 21:33 ` [RFC][PATCH 0/2] ftrace: Add access to function arguments for all callbacks Alexei Starovoitov
2020-10-28 22:07 ` Steven Rostedt
2020-10-28 23:03 ` Alexei Starovoitov
2020-10-28 23:16 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028131909.923504298@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).