From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-kernel@vger.kernel.org
Cc: Nick Desaulniers <ndesaulniers@google.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA
Date: Thu, 29 Oct 2020 20:33:57 +0100 [thread overview]
Message-ID: <20201029193357.389593-1-krzk@kernel.org> (raw)
The pl353-smc driver uses module_amba_driver so it has a build
dependency on CONFIG_ARM_AMBA:
/usr/bin/arm-linux-gnueabi-ld: drivers/memory/pl353-smc.o: in function `pl353_smc_driver_init':
pl353-smc.c:(.init.text+0x10): undefined reference to `amba_driver_register'
However it still can be compile tested on platforms other than ARM,
which in practice is limited to those selecting ARM_AMBA (so only
ARM64).
Reported-by: kernel test robot <lkp@intel.com>
Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/memory/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 00e013b14703..eebd2ddcd860 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -191,8 +191,8 @@ config DA8XX_DDRCTL
config PL353_SMC
tristate "ARM PL35X Static Memory Controller(SMC) driver"
default y if ARM
- depends on ARM
- depends on ARM_AMBA || COMPILE_TEST
+ depends on ARM || COMPILE_TEST
+ depends on ARM_AMBA
help
This driver is for the ARM PL351/PL353 Static Memory
Controller(SMC) module.
--
2.25.1
next reply other threads:[~2020-10-29 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 19:33 Krzysztof Kozlowski [this message]
2020-10-30 0:40 ` [PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA Nick Desaulniers
2020-10-30 6:59 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029193357.389593-1-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).