selftests/seccomp: Update kernel config
diff mbox series

Message ID 20201030121819.764395-1-mic@digikod.net
State New, archived
Headers show
Series
  • selftests/seccomp: Update kernel config
Related show

Commit Message

Mickaël Salaün Oct. 30, 2020, 12:18 p.m. UTC
seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS
to be set.

Cc: Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Tycho Andersen <tycho@tycho.pizza>
Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace")
Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
---
 tools/testing/selftests/seccomp/config | 1 +
 1 file changed, 1 insertion(+)


base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec

Comments

Shuah Khan Nov. 10, 2020, 9:36 p.m. UTC | #1
On 10/30/20 6:18 AM, Mickaël Salaün wrote:
> seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS
> to be set.
> 
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Tycho Andersen <tycho@tycho.pizza>
> Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace")
> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
> ---
>   tools/testing/selftests/seccomp/config | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/seccomp/config b/tools/testing/selftests/seccomp/config
> index 64c19d8eba79..ad431a5178fb 100644
> --- a/tools/testing/selftests/seccomp/config
> +++ b/tools/testing/selftests/seccomp/config
> @@ -1,3 +1,4 @@
> +CONFIG_PID_NS=y
>   CONFIG_SECCOMP=y
>   CONFIG_SECCOMP_FILTER=y
>   CONFIG_USER_NS=y
> 
> base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
> 

Your from and Signed-off-by don't match. Please send the patch
from your igned-off-by address.

WARNING: From:/Signed-off-by: email address mismatch: 'From: "Mickaël 
Salaün" <mic@digikod.net>' != 'Signed-off-by: Mickaël Salaün 
<mic@linux.microsoft.com>'

thanks,
-- Shuah

Patch
diff mbox series

diff --git a/tools/testing/selftests/seccomp/config b/tools/testing/selftests/seccomp/config
index 64c19d8eba79..ad431a5178fb 100644
--- a/tools/testing/selftests/seccomp/config
+++ b/tools/testing/selftests/seccomp/config
@@ -1,3 +1,4 @@ 
+CONFIG_PID_NS=y
 CONFIG_SECCOMP=y
 CONFIG_SECCOMP_FILTER=y
 CONFIG_USER_NS=y