From: Cristian Pop <cristian.pop@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <jic23@kernel.org>, <devicetree@vger.kernel.org>,
<robh+dt@kernel.org>, Cristian Pop <cristian.pop@analog.com>
Subject: [PATCH v7 3/5] iio: adc: ad7768-1: Add channel labels.
Date: Mon, 2 Nov 2020 16:19:58 +0200 [thread overview]
Message-ID: <20201102142000.68916-3-cristian.pop@analog.com> (raw)
In-Reply-To: <20201102142000.68916-1-cristian.pop@analog.com>
For better identification of the channels.
Signed-off-by: Cristian Pop <cristian.pop@analog.com>
---
drivers/iio/adc/ad7768-1.c | 41 ++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 0e93b0766eb4..5c0cbee03230 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -161,6 +161,7 @@ struct ad7768_state {
struct completion completion;
struct iio_trigger *trig;
struct gpio_desc *gpio_sync_in;
+ const char *labels[ARRAY_SIZE(ad7768_channels)];
/*
* DMA (thus cache coherency maintenance) requires the
* transfer buffers to live in their own cache lines.
@@ -407,6 +408,14 @@ static int ad7768_write_raw(struct iio_dev *indio_dev,
}
}
+static int ad7768_read_label(struct iio_dev *indio_dev,
+ const struct iio_chan_spec *chan, char *label)
+{
+ struct ad7768_state *st = iio_priv(indio_dev);
+
+ return sprintf(label, "%s\n", st->labels[chan->channel]);
+}
+
static struct attribute *ad7768_attributes[] = {
&iio_dev_attr_sampling_frequency_available.dev_attr.attr,
NULL
@@ -420,6 +429,7 @@ static const struct iio_info ad7768_info = {
.attrs = &ad7768_group,
.read_raw = &ad7768_read_raw,
.write_raw = &ad7768_write_raw,
+ .read_label = ad7768_read_label,
.debugfs_reg_access = &ad7768_reg_access,
};
@@ -532,6 +542,33 @@ static void ad7768_clk_disable(void *data)
clk_disable_unprepare(st->mclk);
}
+static int ad7768_set_channel_label(struct iio_dev *indio_dev,
+ int num_channels)
+{
+ struct ad7768_state *st = iio_priv(indio_dev);
+ struct device *device = indio_dev->dev.parent;
+ struct fwnode_handle *fwnode;
+ struct fwnode_handle *child;
+ const char *label;
+ int crt_ch = 0;
+
+ fwnode = dev_fwnode(device);
+ fwnode_for_each_child_node(fwnode, child) {
+ if (fwnode_property_read_u32(child, "reg", &crt_ch))
+ continue;
+
+ if (crt_ch >= num_channels)
+ continue;
+
+ if (fwnode_property_read_string(child, "label", &label))
+ continue;
+
+ st->labels[crt_ch] = label;
+ }
+
+ return 0;
+}
+
static int ad7768_probe(struct spi_device *spi)
{
struct ad7768_state *st;
@@ -604,6 +641,10 @@ static int ad7768_probe(struct spi_device *spi)
init_completion(&st->completion);
+ ret = ad7768_set_channel_label(indio_dev, ARRAY_SIZE(ad7768_channels));
+ if (ret)
+ return ret;
+
ret = devm_request_irq(&spi->dev, spi->irq,
&ad7768_interrupt,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
--
2.17.1
next prev parent reply other threads:[~2020-11-02 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 14:19 [PATCH v7 1/5] iio: core: Add optional symbolic label to a device channel Cristian Pop
2020-11-02 14:19 ` [PATCH v7 2/5] iio:Documentation: Add documentation for label channel attribute Cristian Pop
2020-11-02 14:19 ` Cristian Pop [this message]
2020-11-02 14:19 ` [PATCH v7 4/5] dt-bindings:iio:adc:adi,ad7768-1: Add documentation for channel label Cristian Pop
2020-11-05 17:19 ` Rob Herring
2020-11-02 14:20 ` [PATCH v7 5/5] dt-bindings:iio:adc:adc.txt: Add documentation for channel label attribute Cristian Pop
2020-11-05 17:37 ` Rob Herring
2020-11-08 15:29 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2020-11-02 14:16 [PATCH v7 1/5] iio: core: Add optional symbolic label to a device channel Cristian Pop
2020-11-02 14:16 ` [PATCH v7 3/5] iio: adc: ad7768-1: Add channel labels Cristian Pop
2020-09-28 9:09 [PATCH v7 1/5] iio: core: Add optional symbolic label to a device channel Cristian Pop
2020-09-28 9:09 ` [PATCH v7 3/5] iio: adc: ad7768-1: Add channel labels Cristian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102142000.68916-3-cristian.pop@analog.com \
--to=cristian.pop@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).