mfd: at91-usart: do not use compatible to register child devices
diff mbox series

Message ID 20201103093246.1288956-1-codrin.ciubotariu@microchip.com
State Accepted
Commit 4c5840b909f3a12fc5f1275024d0cff6fd23235f
Headers show
Series
  • mfd: at91-usart: do not use compatible to register child devices
Related show

Commit Message

Codrin Ciubotariu Nov. 3, 2020, 9:32 a.m. UTC
There are no separate serial/SPI devices under the at91-usart MFD, but
actually the MFD is used as a serial or a SPI device. There are no DT
sub-nodes for the MFD children, so we should use platform device API to
register the drivers.

Suggested-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
 drivers/mfd/at91-usart.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Lee Jones Nov. 11, 2020, 4:26 p.m. UTC | #1
On Tue, 03 Nov 2020, Codrin Ciubotariu wrote:

> There are no separate serial/SPI devices under the at91-usart MFD, but
> actually the MFD is used as a serial or a SPI device. There are no DT
> sub-nodes for the MFD children, so we should use platform device API to
> register the drivers.
> 
> Suggested-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
>  drivers/mfd/at91-usart.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

Applied, thanks.

Patch
diff mbox series

diff --git a/drivers/mfd/at91-usart.c b/drivers/mfd/at91-usart.c
index 6a8351a4588e..7f08cb60c58b 100644
--- a/drivers/mfd/at91-usart.c
+++ b/drivers/mfd/at91-usart.c
@@ -15,15 +15,11 @@ 
 #include <linux/of.h>
 #include <linux/property.h>
 
-static const struct mfd_cell at91_usart_spi_subdev = {
-	.name = "at91_usart_spi",
-	.of_compatible = "microchip,at91sam9g45-usart-spi",
-};
+static const struct mfd_cell at91_usart_spi_subdev =
+	MFD_CELL_NAME("at91_usart_spi");
 
-static const struct mfd_cell at91_usart_serial_subdev = {
-	.name = "atmel_usart_serial",
-	.of_compatible = "atmel,at91rm9200-usart-serial",
-};
+static const struct mfd_cell at91_usart_serial_subdev =
+	MFD_CELL_NAME("atmel_usart_serial");
 
 static int at91_usart_mode_probe(struct platform_device *pdev)
 {