From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, wahrenst@gmx.net,
linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
p.zabel@pengutronix.de, linux-gpio@vger.kernel.org,
linus.walleij@linaro.org, linux-clk@vger.kernel.org,
sboyd@kernel.org, linux-rpi-kernel@lists.infradead.org,
bgolaszewski@baylibre.com, andy.shevchenko@gmail.com
Subject: [PATCH v3 08/11] firmware: raspberrypi: Get rid of rpi_firmware_get()
Date: Wed, 4 Nov 2020 11:39:34 +0100 [thread overview]
Message-ID: <20201104103938.1286-9-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20201104103938.1286-1-nsaenzjulienne@suse.de>
There a no users left to the function as they all converted to
devm_rpi_firmware_get(). Just get rid of it.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
drivers/firmware/raspberrypi.c | 17 -----------------
include/soc/bcm2835/raspberrypi-firmware.h | 6 ------
2 files changed, 23 deletions(-)
diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index 74bdb3bde9dc..67f7105f3fd2 100644
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -297,23 +297,6 @@ static void rpi_firmware_put(void *data)
wake_up(&fw->wait);
}
-/**
- * rpi_firmware_get - Get pointer to rpi_firmware structure.
- * @firmware_node: Pointer to the firmware Device Tree node.
- *
- * Returns NULL is the firmware device is not ready.
- */
-struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node)
-{
- struct platform_device *pdev = of_find_device_by_node(firmware_node);
-
- if (!pdev)
- return NULL;
-
- return platform_get_drvdata(pdev);
-}
-EXPORT_SYMBOL_GPL(rpi_firmware_get);
-
/**
* devm_rpi_firmware_get - Get pointer to rpi_firmware structure.
* @firmware_node: Pointer to the firmware Device Tree node.
diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
index 8fe64f53a394..eaa4e516e4c6 100644
--- a/include/soc/bcm2835/raspberrypi-firmware.h
+++ b/include/soc/bcm2835/raspberrypi-firmware.h
@@ -140,7 +140,6 @@ int rpi_firmware_property(struct rpi_firmware *fw,
u32 tag, void *data, size_t len);
int rpi_firmware_property_list(struct rpi_firmware *fw,
void *data, size_t tag_size);
-struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node);
struct rpi_firmware *devm_rpi_firmware_get(struct device *dev,
struct device_node *firmware_node);
#else
@@ -156,11 +155,6 @@ static inline int rpi_firmware_property_list(struct rpi_firmware *fw,
return -ENOSYS;
}
-static inline struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node)
-{
- return NULL;
-}
-
static inline struct rpi_firmware *devm_rpi_firmware_get(struct device *dev,
struct device_node *firmware_node)
{
--
2.29.1
next prev parent reply other threads:[~2020-11-04 10:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:39 [PATCH v3 00/11] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() Nicolas Saenz Julienne
2020-11-05 9:13 ` Bartosz Golaszewski
2020-11-05 9:28 ` Nicolas Saenz Julienne
2020-11-05 9:42 ` Bartosz Golaszewski
2020-11-10 13:38 ` Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 02/11] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 03/11] gpio: raspberrypi-exp: " Nicolas Saenz Julienne
2020-11-05 9:08 ` Bartosz Golaszewski
2020-11-04 10:39 ` [PATCH v3 04/11] reset: raspberrypi: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 05/11] soc: bcm: raspberrypi-power: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 06/11] staging: vchiq: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne
2020-11-12 1:45 ` Dmitry Torokhov
2020-11-12 9:06 ` Nicolas Saenz Julienne
2020-11-04 10:39 ` Nicolas Saenz Julienne [this message]
2020-11-04 10:39 ` [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne
2020-11-04 19:06 ` Rob Herring
2020-11-04 19:55 ` Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 11/11] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104103938.1286-9-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=rjui@broadcom.com \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).