From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
Dave Martin <Dave.Martin@arm.com>,
James Clark <james.clark@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Al Grant <Al.Grant@arm.com>, Wei Li <liwei391@huawei.com>,
linux-kernel@vger.kernel.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v7 20/22] perf arm-spe: Add more sub classes for operation packet
Date: Fri, 6 Nov 2020 09:41:34 +0800 [thread overview]
Message-ID: <20201106014136.14103-21-leo.yan@linaro.org> (raw)
In-Reply-To: <20201106014136.14103-1-leo.yan@linaro.org>
For the operation type packet payload with load/store class, it misses
to support these sub classes:
- A load/store targeting the general-purpose registers;
- A load/store targeting unspecified registers;
- The ARMv8.4 nested virtualisation extension can redirect system
register accesses to a memory page controlled by the hypervisor.
The SPE profiling feature in newer implementations can tag those
memory accesses accordingly.
Add the bit pattern describing load/store sub classes, so that the perf
tool can decode it properly.
Inspired by Andre Przywara, refined the commit log and code for more
clear description.
Co-developed-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Leo Yan <leo.yan@linaro.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
---
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
index ea0bbf7c5aa1..ec962a9bff78 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
@@ -343,9 +343,23 @@ static int arm_spe_pkt_desc_op_type(const struct arm_spe_pkt *packet,
arm_spe_pkt_snprintf(&err, &buf, &buf_len, " EXCL");
if (payload & SPE_OP_PKT_AR)
arm_spe_pkt_snprintf(&err, &buf, &buf_len, " AR");
- } else if (SPE_OP_PKT_LDST_SUBCLASS_GET(payload) ==
- SPE_OP_PKT_LDST_SUBCLASS_SIMD_FP) {
+ }
+
+ switch (SPE_OP_PKT_LDST_SUBCLASS_GET(payload)) {
+ case SPE_OP_PKT_LDST_SUBCLASS_SIMD_FP:
arm_spe_pkt_snprintf(&err, &buf, &buf_len, " SIMD-FP");
+ break;
+ case SPE_OP_PKT_LDST_SUBCLASS_GP_REG:
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, " GP-REG");
+ break;
+ case SPE_OP_PKT_LDST_SUBCLASS_UNSPEC_REG:
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, " UNSPEC-REG");
+ break;
+ case SPE_OP_PKT_LDST_SUBCLASS_NV_SYSREG:
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, " NV-SYSREG");
+ break;
+ default:
+ break;
}
break;
case SPE_OP_PKT_HDR_CLASS_BR_ERET:
--
2.17.1
next prev parent reply other threads:[~2020-11-06 1:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 1:41 [PATCH v7 00/22] perf arm-spe: Refactor decoding & dumping flow Leo Yan
2020-11-06 1:41 ` [PATCH v7 01/22] perf arm-spe: Include bitops.h for BIT() macro Leo Yan
2020-11-06 1:41 ` [PATCH v7 02/22] perf arm-spe: Fix a typo in comment Leo Yan
2020-11-06 1:41 ` [PATCH v7 03/22] perf arm-spe: Refactor payload size calculation Leo Yan
2020-11-06 1:41 ` [PATCH v7 04/22] perf arm-spe: Refactor arm_spe_get_events() Leo Yan
2020-11-06 1:41 ` [PATCH v7 05/22] perf arm-spe: Fix packet length handling Leo Yan
2020-11-06 1:41 ` [PATCH v7 06/22] perf arm-spe: Refactor printing string to buffer Leo Yan
2020-11-09 12:58 ` André Przywara
2020-11-06 1:41 ` [PATCH v7 07/22] perf arm-spe: Consolidate arm_spe_pkt_desc()'s return value Leo Yan
2020-11-09 16:52 ` André Przywara
2020-11-10 10:22 ` Leo Yan
2020-11-06 1:41 ` [PATCH v7 08/22] perf arm-spe: Refactor packet header parsing Leo Yan
2020-11-06 1:41 ` [PATCH v7 09/22] perf arm-spe: Add new function arm_spe_pkt_desc_addr() Leo Yan
2020-11-06 1:41 ` [PATCH v7 10/22] perf arm-spe: Refactor address packet handling Leo Yan
2020-11-06 1:41 ` [PATCH v7 11/22] perf arm_spe: Fixup top byte for data virtual address Leo Yan
2020-11-06 1:41 ` [PATCH v7 12/22] perf arm-spe: Refactor context packet handling Leo Yan
2020-11-06 1:41 ` [PATCH v7 13/22] perf arm-spe: Add new function arm_spe_pkt_desc_counter() Leo Yan
2020-11-06 1:41 ` [PATCH v7 14/22] perf arm-spe: Refactor counter packet handling Leo Yan
2020-11-06 1:41 ` [PATCH v7 15/22] perf arm-spe: Add new function arm_spe_pkt_desc_event() Leo Yan
2020-11-06 1:41 ` [PATCH v7 16/22] perf arm-spe: Refactor event type handling Leo Yan
2020-11-06 1:41 ` [PATCH v7 17/22] perf arm-spe: Remove size condition checking for events Leo Yan
2020-11-06 1:41 ` [PATCH v7 18/22] perf arm-spe: Add new function arm_spe_pkt_desc_op_type() Leo Yan
2020-11-06 1:41 ` [PATCH v7 19/22] perf arm-spe: Refactor operation packet handling Leo Yan
2020-11-06 1:41 ` Leo Yan [this message]
2020-11-06 1:41 ` [PATCH v7 21/22] perf arm_spe: Decode memory tagging properties Leo Yan
2020-11-06 1:41 ` [PATCH v7 22/22] perf arm-spe: Add support for ARMv8.3-SPE Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106014136.14103-21-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=Al.Grant@arm.com \
--cc=Dave.Martin@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andre.przywara@arm.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).