linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@linux.alibaba.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked
Date: Fri,  6 Nov 2020 19:24:55 +0800	[thread overview]
Message-ID: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> (raw)

Otherwise it cause gcc warning:
          ^~~~~~~~~~~~~~~
../mm/filemap.c:830:14: warning: no previous prototype for
‘__add_to_page_cache_locked’ [-Wmissing-prototypes]
 noinline int __add_to_page_cache_locked(struct page *page,
              ^~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Andrew Morton <akpm@linux-foundation.org> 
Cc: linux-mm@kvack.org 
Cc: linux-kernel@vger.kernel.org 
---
 mm/filemap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index d90614f501da..249cf489f5df 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -827,7 +827,7 @@ int replace_page_cache_page(struct page *old, struct page *new, gfp_t gfp_mask)
 }
 EXPORT_SYMBOL_GPL(replace_page_cache_page);
 
-noinline int __add_to_page_cache_locked(struct page *page,
+static noinline int __add_to_page_cache_locked(struct page *page,
 					struct address_space *mapping,
 					pgoff_t offset, gfp_t gfp,
 					void **shadowp)
-- 
1.8.3.1


             reply	other threads:[~2020-11-06 11:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 11:24 Alex Shi [this message]
2020-11-06 18:24 ` [PATCH] mm/filemap: add static for function __add_to_page_cache_locked Ira Weiny
2020-11-10  3:09 ` Souptick Joarder
2020-11-10 11:58   ` Alex Shi
2020-11-10 19:50   ` Andrew Morton
2020-11-12  0:18     ` Alex Shi
2020-12-07  8:11       ` Greg Thelen
2020-12-07  8:15       ` Michal Kubecek
2020-12-07 18:35         ` Justin Forbes
2020-12-07 22:44           ` Alexei Starovoitov
2020-12-07 22:53             ` Michal Kubecek
2020-12-07 22:59               ` Alexei Starovoitov
2020-12-08  1:12                 ` Alexei Starovoitov
2020-12-09 14:46                   ` Stanislaw Gruszka
2020-12-09 15:08                     ` Matthew Wilcox
2020-12-09 15:51                       ` Stanislaw Gruszka
2020-12-09 18:05                         ` Christoph Hellwig
2020-12-09 22:32                           ` Steven Rostedt
2020-12-10  1:12                             ` Alexei Starovoitov
2020-12-10  2:31                               ` Steven Rostedt
2020-12-10  3:02                                 ` Alexei Starovoitov
2020-12-09 20:59               ` Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com \
    --to=alex.shi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).