From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH] ARM: dts: imx6qdl: specify vcc-supply for NOP USB PHYs
Date: Fri, 13 Nov 2020 16:28:55 +0100 [thread overview]
Message-ID: <20201113152856.3758-1-a.fatoum@pengutronix.de> (raw)
The SoC dtsi lists a NOP USB PHY for each of the two HSIC-only USB
controllers. Their device tree node doesn't indicate a vcc-supply
resulting in:
usb_phy_generic usbphynop1: supply vcc not found, using dummy regulator
usb_phy_generic usbphynop2: supply vcc not found, using dummy regulator
warnings on boot up. The USB IP vcc-supply - separate from the vusb - is
hardwired to LDO_2P5[1], which we already have a device tree node for.
Reference it for the dummy "phy" as well.
This will lead to breakage (probe deferment) for kernels that:
- Use a HSIC USB controller
- Use this new device tree
- but have CONFIG_REGULATOR_ANATOP disabled
Because while the regulator is always-on, it can't be resolved when
there is no driver for it.
As there are
- no affected upstream device trees
- existing device trees are unaffected without recompilation
- disabling CONFIG_REGULATOR_ANATOP is explicitly a non-recommended
configuration per symbol help text
this potential breakage is deemed acceptable.
[1]: i.MX 6Dual/6Quad Reference Manual, Rev. C,
Figure 53-1. Power System Overview
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 43edbf1156c7..22e4c142de13 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -131,11 +131,13 @@ pmu: pmu {
usbphynop1: usbphynop1 {
compatible = "usb-nop-xceiv";
+ vcc-supply = <®_vdd2p5>;
#phy-cells = <0>;
};
usbphynop2: usbphynop2 {
compatible = "usb-nop-xceiv";
+ vcc-supply = <®_vdd2p5>;
#phy-cells = <0>;
};
--
2.28.0
next reply other threads:[~2020-11-13 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 15:28 Ahmad Fatoum [this message]
2021-01-18 10:41 ` [RFC PATCH] ARM: dts: imx6qdl: specify vcc-supply for NOP USB PHYs Ahmad Fatoum
2021-01-19 8:57 ` Shawn Guo
2021-01-19 9:20 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113152856.3758-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).