[1/2] x86: apic - calibrate_APIC_clock remove redundant irq-enable-disable
diff mbox series

Message ID 4916c290.0437560a.270e.0940@mx.google.com
State New, archived
Headers show
Series
  • [1/2] x86: apic - calibrate_APIC_clock remove redundant irq-enable-disable
Related show

Commit Message

Cyrill Gorcunov Jan. 1, 1970, midnight UTC
Impact: cleanup

lapic_timer_setup is self-protected with local_irq_save/restore
no need to use them in caller and levt is the per-cpu variable so
no concurrent access from another cpu.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
 arch/x86/kernel/apic.c |    4 ----
 1 file changed, 4 deletions(-)

Comments

Cyrill Gorcunov Nov. 9, 2008, 11:05 a.m. UTC | #1
[Cyrill Gorcunov - Thu, Jan 01, 1970 at 03:00:01AM +0300]
| Impact: cleanup
| 
| lapic_timer_setup is self-protected with local_irq_save/restore
| no need to use them in caller and levt is the per-cpu variable so
| no concurrent access from another cpu.
| 
| Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| ---
|  arch/x86/kernel/apic.c |    4 ----
|  1 file changed, 4 deletions(-)
|
...

Oh... it happend again -- 'Jan 01, 1970' dated message gone out.
Sorry for that! Seems sendmail does screw somehow quilt passed args...

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Maciej W. Rozycki Nov. 9, 2008, 12:45 p.m. UTC | #2
On Thu, 1 Jan 1970, Cyrill Gorcunov wrote:

> Impact: cleanup
> 
> lapic_timer_setup is self-protected with local_irq_save/restore
> no need to use them in caller and levt is the per-cpu variable so
> no concurrent access from another cpu.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>  arch/x86/kernel/apic.c |    4 ----
>  1 file changed, 4 deletions(-)

Acked-by: Maciej W. Rozycki <macro@linux-mips.org>

 Thanks, Cyrill.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
tip-bot for Ingo Molnar Nov. 10, 2008, 8:17 a.m. UTC | #3
* Maciej W. Rozycki <macro@linux-mips.org> wrote:

> On Thu, 1 Jan 1970, Cyrill Gorcunov wrote:
> 
> > Impact: cleanup
> > 
> > lapic_timer_setup is self-protected with local_irq_save/restore
> > no need to use them in caller and levt is the per-cpu variable so
> > no concurrent access from another cpu.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > ---
> >  arch/x86/kernel/apic.c |    4 ----
> >  1 file changed, 4 deletions(-)
> 
> Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
> 
>  Thanks, Cyrill.

applied to tip/x86/apic, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

Index: linux-2.6.git/arch/x86/kernel/apic.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/apic.c
+++ linux-2.6.git/arch/x86/kernel/apic.c
@@ -672,13 +672,9 @@  static int __init calibrate_APIC_clock(v
 		while (lapic_cal_loops <= LAPIC_CAL_LOOPS)
 			cpu_relax();
 
-		local_irq_disable();
-
 		/* Stop the lapic timer */
 		lapic_timer_setup(CLOCK_EVT_MODE_SHUTDOWN, levt);
 
-		local_irq_enable();
-
 		/* Jiffies delta */
 		deltaj = lapic_cal_j2 - lapic_cal_j1;
 		apic_printk(APIC_VERBOSE, "... jiffies delta = %lu\n", deltaj);