pinctrl: at91-pio4: Make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix build error
diff mbox series

Message ID 1606209423-4742-1-git-send-email-yangtiezhu@loongson.cn
State Accepted
Commit 0a03658d222a99b192a7f84e41e8af197a87259e
Headers show
Series
  • pinctrl: at91-pio4: Make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix build error
Related show

Commit Message

Tiezhu Yang Nov. 24, 2020, 9:17 a.m. UTC
If CONFIG_HAS_IOMEM is not set, devm_platform_ioremap_resource() will
be not built in drivers/base/platform.c and then there exists a build
error about undefined reference to "devm_platform_ioremap_resource"
in pinctrl-at91-pio4.c under COMPILE_TEST and CONFIG_PINCTRL_AT91PIO4,
make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix it.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij Dec. 4, 2020, 8:55 a.m. UTC | #1
On Tue, Nov 24, 2020 at 10:17 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:

> If CONFIG_HAS_IOMEM is not set, devm_platform_ioremap_resource() will
> be not built in drivers/base/platform.c and then there exists a build
> error about undefined reference to "devm_platform_ioremap_resource"
> in pinctrl-at91-pio4.c under COMPILE_TEST and CONFIG_PINCTRL_AT91PIO4,
> make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Patch applied as non-critical fix for v5.11.

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 8150953..d132e1a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -82,6 +82,7 @@  config PINCTRL_AT91
 config PINCTRL_AT91PIO4
 	bool "AT91 PIO4 pinctrl driver"
 	depends on OF
+	depends on HAS_IOMEM
 	depends on ARCH_AT91 || COMPILE_TEST
 	select PINMUX
 	select GENERIC_PINCONF