From: Marco Elver <elver@google.com>
To: elver@google.com, davem@davemloft.net, kuba@kernel.org,
johannes@sipsolutions.net
Cc: akpm@linux-foundation.org, a.nogikh@gmail.com,
edumazet@google.com, andreyknvl@google.com, dvyukov@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, idosch@idosch.org, fw@strlen.de,
willemb@google.com, Aleksandr Nogikh <nogikh@google.com>
Subject: [PATCH v6 1/3] kernel: make kcov_common_handle consider the current context
Date: Wed, 25 Nov 2020 17:24:53 +0100 [thread overview]
Message-ID: <20201125162455.1690502-2-elver@google.com> (raw)
In-Reply-To: <20201125162455.1690502-1-elver@google.com>
From: Aleksandr Nogikh <nogikh@google.com>
kcov_common_handle is a method that is used to obtain a "default" KCOV
remote handle of the current process. The handle can later be passed
to kcov_remote_start in order to collect coverage for the processing
that is initiated by one process, but done in another. For details see
Documentation/dev-tools/kcov.rst and comments in kernel/kcov.c.
Presently, if kcov_common_handle is called in an IRQ context, it will
return a handle for the interrupted process. This may lead to
unreliable and incorrect coverage collection.
Adjust the behavior of kcov_common_handle in the following way. If it
is called in a task context, return the common handle for the
currently running task. Otherwise, return 0.
Signed-off-by: Aleksandr Nogikh <nogikh@google.com>
Signed-off-by: Marco Elver <elver@google.com>
Reviewed-by: Andrey Konovalov <andreyknvl@google.com>
---
kernel/kcov.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/kcov.c b/kernel/kcov.c
index 6b8368be89c8..80bfe71bbe13 100644
--- a/kernel/kcov.c
+++ b/kernel/kcov.c
@@ -1023,6 +1023,8 @@ EXPORT_SYMBOL(kcov_remote_stop);
/* See the comment before kcov_remote_start() for usage details. */
u64 kcov_common_handle(void)
{
+ if (!in_task())
+ return 0;
return current->kcov_handle;
}
EXPORT_SYMBOL(kcov_common_handle);
--
2.29.2.454.gaff20da3a2-goog
next prev parent reply other threads:[~2020-11-25 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 16:24 [PATCH v6 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling Marco Elver
2020-11-25 16:24 ` Marco Elver [this message]
2020-11-25 16:24 ` [PATCH v6 2/3] net: store KCOV remote handle in sk_buff Marco Elver
2020-11-25 16:24 ` [PATCH v6 3/3] mac80211: add KCOV remote annotations to incoming frame processing Marco Elver
2020-11-25 16:44 ` [PATCH v6 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling Florian Westphal
2020-11-25 16:45 ` Jakub Kicinski
2020-11-25 16:50 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125162455.1690502-2-elver@google.com \
--to=elver@google.com \
--cc=a.nogikh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=idosch@idosch.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nogikh@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).