platform/chrome: cros_ec_typec: Decouple cable remove on disconnect
diff mbox series

Message ID
State New, archived
Headers show
  • platform/chrome: cros_ec_typec: Decouple cable remove on disconnect
Related show

Commit Message

Prashant Malani Nov. 25, 2020, 6:34 p.m. UTC
Type C cable objects are independent of partner objects. Don't return
if a partner object is not registered (mostly in the case of an error
while registering a partner), and instead treat the removal of partner
and cable objects on disconnect independently.

Cc: Benson Leung <>
Signed-off-by: Prashant Malani <>

This patch should be applied on top of the series[1] which adds support
for cable & plugs to cros-ec-typec.


 drivers/platform/chrome/cros_ec_typec.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff mbox series

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 65c5d0090ccd..8294486908ca 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -626,9 +626,8 @@  static void cros_typec_set_port_params_v1(struct cros_typec_data *typec,
 				 "Failed to register partner on port: %d\n",
 	} else {
-		if (!typec->ports[port_num]->partner)
-			return;
-		cros_typec_remove_partner(typec, port_num);
+		if (typec->ports[port_num]->partner)
+			cros_typec_remove_partner(typec, port_num);
 		if (typec->ports[port_num]->cable)
 			cros_typec_remove_cable(typec, port_num);