drivers: clocksource: timer-riscv: Depend on the SBI
diff mbox series

Message ID 20201125195804.3780975-1-palmer@dabbelt.com
State New, archived
Headers show
Series
  • drivers: clocksource: timer-riscv: Depend on the SBI
Related show

Commit Message

Palmer Dabbelt Nov. 25, 2020, 7:58 p.m. UTC
From: Palmer Dabbelt <palmerdabbelt@google.com>

Fundamentally this is an SBI timer driver, so it cannot be enabled without
support for the RISC-V SBI.

Fixes: d5be89a8d118 ("RISC-V: Resurrect the MMIO timer implementation for M-mode systems")
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Kefeng Wang Nov. 26, 2020, 1 a.m. UTC | #1
Hi Palmer,  I send a same patch and have been acked from you : )

https://patchwork.kernel.org/project/linux-riscv/patch/20201028131230.72907-1-wangkefeng.wang@huawei.com/

On 2020/11/26 3:58, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> Fundamentally this is an SBI timer driver, so it cannot be enabled without
> support for the RISC-V SBI.
>
> Fixes: d5be89a8d118 ("RISC-V: Resurrect the MMIO timer implementation for M-mode systems")
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
>   drivers/clocksource/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 68b087bff59c..3eeaf0efba8f 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -655,6 +655,7 @@ config ATCPIT100_TIMER
>   config RISCV_TIMER
>   	bool "Timer for the RISC-V platform" if COMPILE_TEST
>   	depends on GENERIC_SCHED_CLOCK && RISCV
> +	depends on RISCV_SBI
>   	select TIMER_PROBE
>   	select TIMER_OF
>   	help

Patch
diff mbox series

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 68b087bff59c..3eeaf0efba8f 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -655,6 +655,7 @@  config ATCPIT100_TIMER
 config RISCV_TIMER
 	bool "Timer for the RISC-V platform" if COMPILE_TEST
 	depends on GENERIC_SCHED_CLOCK && RISCV
+	depends on RISCV_SBI
 	select TIMER_PROBE
 	select TIMER_OF
 	help