[v1] net: phy: micrel: fix interrupt handling
diff mbox series

Message ID 20201127123621.31234-1-o.rempel@pengutronix.de
State Accepted
Commit fff4c74690018c4f741d1ae68c2ba2143b66844a
Headers show
Series
  • [v1] net: phy: micrel: fix interrupt handling
Related show

Commit Message

Oleksij Rempel Nov. 27, 2020, 12:36 p.m. UTC
After migration to the shared interrupt support, the KSZ8031 PHY with
enabled interrupt support was not able to notify about link status
change.

Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/phy/micrel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn Nov. 27, 2020, 2:45 p.m. UTC | #1
On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:
> After migration to the shared interrupt support, the KSZ8031 PHY with
> enabled interrupt support was not able to notify about link status
> change.
> 
> Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

I took a quick look at all the other patches like this. I did not spot
any other missing the !

    Andrew
Ioana Ciornei Nov. 27, 2020, 3:11 p.m. UTC | #2
On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote:
> On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:
> > After migration to the shared interrupt support, the KSZ8031 PHY with
> > enabled interrupt support was not able to notify about link status
> > change.
> > 
> > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> 
> I took a quick look at all the other patches like this. I did not spot
> any other missing the !
> 
>     Andrew

Uhh, really sorry for this!

Thanks for double checking.

Ioana
Jakub Kicinski Nov. 28, 2020, 1:27 a.m. UTC | #3
On Fri, 27 Nov 2020 15:11:08 +0000 Ioana Ciornei wrote:
> On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote:
> > On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:  
> > > After migration to the shared interrupt support, the KSZ8031 PHY with
> > > enabled interrupt support was not able to notify about link status
> > > change.
> > > 
> > > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>  
> > 
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > 
> > I took a quick look at all the other patches like this. I did not spot
> > any other missing the !
> > 
> >     Andrew  
> 
> Uhh, really sorry for this!
> 
> Thanks for double checking.

Applied, thanks!

Patch
diff mbox series

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 97f08f20630b..54e0d75203da 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -207,7 +207,7 @@  static irqreturn_t kszphy_handle_interrupt(struct phy_device *phydev)
 		return IRQ_NONE;
 	}
 
-	if ((irq_status & KSZPHY_INTCS_STATUS))
+	if (!(irq_status & KSZPHY_INTCS_STATUS))
 		return IRQ_NONE;
 
 	phy_trigger_machine(phydev);