From: Hanks Chen <hanks.chen@mediatek.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
CC Hwang <cc.hwang@mediatek.com>,
Kuohong Wang <kuohong.wang@mediatek.com>,
Loda Chou <loda.chou@mediatek.com>,
Hanks Chen <hanks.chen@mediatek.com>
Subject: [PATCH v1 2/3] arm: disable irq on cpu shutdown flow
Date: Fri, 27 Nov 2020 22:15:30 +0800 [thread overview]
Message-ID: <1606486531-25719-3-git-send-email-hanks.chen@mediatek.com> (raw)
In-Reply-To: <1606486531-25719-1-git-send-email-hanks.chen@mediatek.com>
Disable irq on cpu shutdown flow to ensure interrupts
did not bother this cpu after status as offline.
To avoid suspicious RCU usage
[0:swapper/0]RCU used illegally from offline CPU! ...
[0:swapper/0]lockdep: [name:lockdep&]cpu_id = 0, cpu_is_offline = 1
Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
---
arch/arm/kernel/smp.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 48099c6e1e4a..6b8f72490320 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -262,6 +262,12 @@ int __cpu_disable(void)
remove_cpu_topology(cpu);
#endif
+ /*
+ * we disable irq here to ensure interrupts
+ * did not bother this cpu after status as offline.
+ */
+ local_irq_disable();
+
/*
* Take this CPU offline. Once we clear this, we can't return,
* and we must not schedule until we're ready to give up the cpu.
@@ -600,11 +606,11 @@ static void ipi_cpu_stop(unsigned int cpu)
raw_spin_unlock(&stop_lock);
}
- set_cpu_online(cpu, false);
-
local_fiq_disable();
local_irq_disable();
+ set_cpu_online(cpu, false);
+
while (1) {
cpu_relax();
wfe();
--
2.18.0
next prev parent reply other threads:[~2020-11-27 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 14:15 Support 1 of N SPI interrupt for interrupt distribution Hanks Chen
2020-11-27 14:15 ` [PATCH v1 1/3] irqchip/gic: enable irq target all Hanks Chen
2020-11-27 18:11 ` Marc Zyngier
2020-11-27 18:56 ` Catalin Marinas
2020-11-27 19:43 ` Marc Zyngier
2020-12-01 13:54 ` Hanks Chen
2020-12-02 11:09 ` Thomas Gleixner
2020-11-27 14:15 ` Hanks Chen [this message]
2020-11-27 14:15 ` [PATCH v1 3/3] arm64: disable irq on cpu shutdown flow Hanks Chen
2020-11-27 18:27 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1606486531-25719-3-git-send-email-hanks.chen@mediatek.com \
--to=hanks.chen@mediatek.com \
--cc=catalin.marinas@arm.com \
--cc=cc.hwang@mediatek.com \
--cc=jason@lakedaemon.net \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=loda.chou@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).