misc: altera-stapl: remove trailing semicolon in macro definition
diff mbox series

Message ID 20201127165421.2692469-1-trix@redhat.com
State New, archived
Headers show
Series
  • misc: altera-stapl: remove trailing semicolon in macro definition
Related show

Commit Message

Tom Rix Nov. 27, 2020, 4:54 p.m. UTC
From: Tom Rix <trix@redhat.com>

The macro use will already have a semicolon.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Greg Kroah-Hartman Nov. 27, 2020, 5:03 p.m. UTC | #1
On Fri, Nov 27, 2020 at 08:54:21AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> The macro use will already have a semicolon.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/altera-stapl/altera-jtag.c b/drivers/misc/altera-stapl/altera-jtag.c
> index 27e8e0c9e8cf..0238600107b0 100644
> --- a/drivers/misc/altera-stapl/altera-jtag.c
> +++ b/drivers/misc/altera-stapl/altera-jtag.c
> @@ -17,9 +17,9 @@
>  #include "altera-jtag.h"
>  
>  #define	alt_jtag_io(a, b, c)\
> -		astate->config->jtag_io(astate->config->dev, a, b, c);
> +		astate->config->jtag_io(astate->config->dev, a, b, c)
>  
> -#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL);
> +#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL)

Ick, really?  That macro should be removed entirely.  Can you redo this
as a 2 patch series, the first for the alt_jtag_io() change, and the
other to remove all users of alt_malloc()?

thanks,

greg k-h
Tom Rix Nov. 27, 2020, 5:42 p.m. UTC | #2
On 11/27/20 9:03 AM, Greg KH wrote:
> On Fri, Nov 27, 2020 at 08:54:21AM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>  drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/misc/altera-stapl/altera-jtag.c b/drivers/misc/altera-stapl/altera-jtag.c
>> index 27e8e0c9e8cf..0238600107b0 100644
>> --- a/drivers/misc/altera-stapl/altera-jtag.c
>> +++ b/drivers/misc/altera-stapl/altera-jtag.c
>> @@ -17,9 +17,9 @@
>>  #include "altera-jtag.h"
>>  
>>  #define	alt_jtag_io(a, b, c)\
>> -		astate->config->jtag_io(astate->config->dev, a, b, c);
>> +		astate->config->jtag_io(astate->config->dev, a, b, c)
>>  
>> -#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL);
>> +#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL)
> Ick, really?  That macro should be removed entirely.  Can you redo this
> as a 2 patch series, the first for the alt_jtag_io() change, and the
> other to remove all users of alt_malloc()?

yes.

It may be a bit, I would like to see if there are other similar wrappers.

Tom

>
> thanks,
>
> greg k-h
>

Patch
diff mbox series

diff --git a/drivers/misc/altera-stapl/altera-jtag.c b/drivers/misc/altera-stapl/altera-jtag.c
index 27e8e0c9e8cf..0238600107b0 100644
--- a/drivers/misc/altera-stapl/altera-jtag.c
+++ b/drivers/misc/altera-stapl/altera-jtag.c
@@ -17,9 +17,9 @@ 
 #include "altera-jtag.h"
 
 #define	alt_jtag_io(a, b, c)\
-		astate->config->jtag_io(astate->config->dev, a, b, c);
+		astate->config->jtag_io(astate->config->dev, a, b, c)
 
-#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL);
+#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL)
 
 /*
  * This structure shows, for each JTAG state, which state is reached after