scsi: qla2xxx: remove trailing semicolon in macro definition
diff mbox series

Message ID 20201127182741.2801597-1-trix@redhat.com
State New, archived
Headers show
Series
  • scsi: qla2xxx: remove trailing semicolon in macro definition
Related show

Commit Message

Tom Rix Nov. 27, 2020, 6:27 p.m. UTC
From: Tom Rix <trix@redhat.com>

The macro use will already have a semicolon.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/scsi/qla2xxx/qla_def.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Wagner Nov. 30, 2020, 9:17 a.m. UTC | #1
Hi Tom,

On Fri, Nov 27, 2020 at 10:27:41AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> The macro use will already have a semicolon.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Daniel Wagner <dwagner@suse.de>

> ---
>  drivers/scsi/qla2xxx/qla_def.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index ed9b10f8537d..86d249551b2d 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
>  } while (0)
>  
>  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
> -	atomic_dec(&__qpair->ref_count);		\
> +	atomic_dec(&__qpair->ref_count)		\

Nitpick, please insert an additional tab after the remove so that the
backlashes align again.

Thanks,
Daniel
Daniel Wagner Nov. 30, 2020, 9:34 a.m. UTC | #2
On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej ┼╗enczykowski wrote:
> On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner <dwagner@suse.de> wrote:
> > >  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)             \
> > > -     atomic_dec(&__qpair->ref_count);                \
> > > +     atomic_dec(&__qpair->ref_count)         \
> >
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> >
> 
> Uhm, if there's no semicolon, then presumably it's the final line of the
> macro, and thus there should be no tabs and no backslash at the end of the
> line.

Right! Didn't realize it. The backslash should be removed.
Tom Rix Nov. 30, 2020, 4:16 p.m. UTC | #3
On 11/30/20 1:17 AM, Daniel Wagner wrote:
> Hi Tom,
>
> On Fri, Nov 27, 2020 at 10:27:41AM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
>
>> ---
>>  drivers/scsi/qla2xxx/qla_def.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
>> index ed9b10f8537d..86d249551b2d 100644
>> --- a/drivers/scsi/qla2xxx/qla_def.h
>> +++ b/drivers/scsi/qla2xxx/qla_def.h
>> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
>>  } while (0)
>>  
>>  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
>> -	atomic_dec(&__qpair->ref_count);		\
>> +	atomic_dec(&__qpair->ref_count)		\
> Nitpick, please insert an additional tab after the remove so that the
> backlashes align again.

How about removing the last escaped newline and the next empty line ?

Tom

>
> Thanks,
> Daniel
>
Daniel Wagner Nov. 30, 2020, 4:30 p.m. UTC | #4
> >>  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
> >> -	atomic_dec(&__qpair->ref_count);		\
> >> +	atomic_dec(&__qpair->ref_count)		\
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> 
> How about removing the last escaped newline and the next empty line ?

Yes please.

Patch
diff mbox series

diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index ed9b10f8537d..86d249551b2d 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -4970,7 +4970,7 @@  struct secure_flash_update_block_pk {
 } while (0)
 
 #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
-	atomic_dec(&__qpair->ref_count);		\
+	atomic_dec(&__qpair->ref_count)		\
 
 
 #define QLA_ENA_CONF(_ha) {\