From: Alexander Dahl <post@lespocky.de>
To: Rob Herring <robh+dt@kernel.org>
Cc: Alexander Dahl <ada@thorsis.com>,
linux-leds@vger.kernel.org, Alexander Dahl <post@lespocky.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: [PATCH v8 3/5] ARM: dts: stm32: Fix schema warnings for pwm-leds
Date: Sat, 28 Nov 2020 22:53:51 +0100 [thread overview]
Message-ID: <20201128215353.3991-4-post@lespocky.de> (raw)
In-Reply-To: <20201128215353.3991-1-post@lespocky.de>
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
* updated indexes and added comment (Ahmad Fatoum)
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
index 1e5333fd437f..5ed58110d963 100644
--- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
@@ -36,34 +36,35 @@
stdout-path = &uart4;
};
- led-act {
+ led-controller-0 {
compatible = "gpio-leds";
- led-green {
+ led-0 {
label = "mc1:green:act";
gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
};
- led-rgb {
+ led-controller-1 {
compatible = "pwm-leds";
- led-red {
+ /* led-1 to led-3 are part of a single RGB led */
+ led-1 {
label = "mc1:red:rgb";
pwms = <&leds_pwm 1 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-green {
+ led-2 {
label = "mc1:green:rgb";
pwms = <&leds_pwm 2 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-blue {
+ led-3 {
label = "mc1:blue:rgb";
pwms = <&leds_pwm 3 1000000 0>;
max-brightness = <255>;
--
2.20.1
next prev parent reply other threads:[~2020-11-28 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 21:53 [PATCH v8 0/5] leds: pwm: Make automatic labels work Alexander Dahl
2020-11-28 21:53 ` [PATCH v8 1/5] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-11-28 21:53 ` [PATCH v8 2/5] ARM: dts: berlin: " Alexander Dahl
2020-11-28 21:53 ` Alexander Dahl [this message]
2020-11-28 22:00 ` [Linux-stm32] [PATCH v8 3/5] ARM: dts: stm32: " Ahmad Fatoum
2020-11-28 21:53 ` [PATCH v8 4/5] arm64: dts: meson: " Alexander Dahl
2020-11-28 21:53 ` [PATCH v8 5/5] MIPS: DTS: img: " Alexander Dahl
2020-12-07 10:32 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128215353.3991-4-post@lespocky.de \
--to=post@lespocky.de \
--cc=ada@thorsis.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).