From: Eli Cohen <elic@nvidia.com>
To: <mst@redhat.com>, <jasowang@redhat.com>,
<virtualization@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Cc: <lulu@redhat.com>, Eli Cohen <elic@nvidia.com>
Subject: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance
Date: Sun, 29 Nov 2020 08:43:51 +0200 [thread overview]
Message-ID: <20201129064351.63618-1-elic@nvidia.com> (raw)
We should not try to use the VF MAC address as that is used by the
regular (e.g. mlx5_core) NIC implementation. Instead, use a random
generated MAC address.
Suggested by: Cindy Lu <lulu@redhat.com>
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen <elic@nvidia.com>
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index 1fa6fcac8299..80d06d958b8b 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1955,10 +1955,7 @@ void *mlx5_vdpa_add_dev(struct mlx5_core_dev *mdev)
if (err)
goto err_mtu;
- err = mlx5_query_nic_vport_mac_address(mdev, 0, 0, config->mac);
- if (err)
- goto err_mtu;
-
+ eth_random_addr(config->mac);
mvdev->vdev.dma_dev = mdev->device;
err = mlx5_vdpa_alloc_resources(&ndev->mvdev);
if (err)
--
2.26.2
next reply other threads:[~2020-11-29 6:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 6:43 Eli Cohen [this message]
2020-11-29 20:08 ` [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance Michael S. Tsirkin
2020-11-30 6:27 ` Eli Cohen
2020-11-30 9:00 ` Michael S. Tsirkin
2020-11-30 9:27 ` Eli Cohen
2020-11-30 9:33 ` Michael S. Tsirkin
2020-11-30 10:41 ` Cindy Lu
2020-11-30 15:33 ` Michael S. Tsirkin
2020-12-01 9:23 ` Cindy Lu
2020-12-01 11:32 ` Michael S. Tsirkin
2020-12-02 2:27 ` Cindy Lu
2020-12-02 4:18 ` Jason Wang
2020-12-02 5:57 ` Eli Cohen
2020-12-02 9:23 ` Michael S. Tsirkin
2020-12-02 12:12 ` Eli Cohen
2020-12-02 12:17 ` Michael S. Tsirkin
2020-12-02 13:00 ` Jason Wang
2020-12-02 13:07 ` Michael S. Tsirkin
2020-12-02 13:33 ` Jason Wang
2020-12-02 13:48 ` Jason Wang
2020-12-02 22:00 ` Michael S. Tsirkin
2020-12-03 6:49 ` Eli Cohen
2020-12-03 10:44 ` Michael S. Tsirkin
2020-12-03 12:09 ` Eli Cohen
2020-12-03 12:15 ` Michael S. Tsirkin
2020-12-03 12:24 ` Eli Cohen
2020-12-04 2:53 ` Jason Wang
2020-12-06 6:54 ` Eli Cohen
2020-12-02 9:30 ` Michael S. Tsirkin
2020-12-02 12:56 ` Jason Wang
2020-12-02 13:04 ` Michael S. Tsirkin
2020-12-02 13:41 ` Jason Wang
2020-11-30 11:51 ` Eli Cohen
2020-11-30 15:30 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201129064351.63618-1-elic@nvidia.com \
--to=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).