SCSI: bnx2i: requires MMU
diff mbox series

Message ID 20201129070916.3919-1-rdunlap@infradead.org
State Accepted
Commit 2d586494c4a001312650f0b919d534e429dd1e09
Headers show
Series
  • SCSI: bnx2i: requires MMU
Related show

Commit Message

Randy Dunlap Nov. 29, 2020, 7:09 a.m. UTC
The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO,
which depends on MMU.
Since 'select' does not follow dependency chains, add the same MMU
dependency to SCSI_BNX2_ISCSI.

Quietens this kconfig warning:

WARNING: unmet direct dependencies detected for CNIC
  Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && PCI [=y] && (IPV6 [=m] || IPV6 [=m]=n) && MMU [=n]
  Selected by [m]:
  - SCSI_BNX2_ISCSI [=m] && SCSI_LOWLEVEL [=y] && SCSI [=y] && NET [=y] && PCI [=y] && (IPV6 [=m] || IPV6 [=m]=n)

Fixes: cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-scsi@vger.kernel.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Manish Rangankar <mrangankar@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
---
 drivers/scsi/bnx2i/Kconfig            |    1 +
 1 file changed, 1 insertions(+)

Comments

Martin K. Petersen Dec. 1, 2020, 5:32 a.m. UTC | #1
Randy,

> The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO,
> which depends on MMU.  Since 'select' does not follow dependency
> chains, add the same MMU dependency to SCSI_BNX2_ISCSI.

Applied to 5.11/scsi-staging, thanks!
Martin K. Petersen Dec. 3, 2020, 8:45 p.m. UTC | #2
On Sat, 28 Nov 2020 23:09:16 -0800, Randy Dunlap wrote:

> The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO,
> which depends on MMU.
> Since 'select' does not follow dependency chains, add the same MMU
> dependency to SCSI_BNX2_ISCSI.
> 
> Quietens this kconfig warning:
> 
> [...]

Applied to 5.10/scsi-fixes, thanks!

[1/1] SCSI: bnx2i: requires MMU
      https://git.kernel.org/mkp/scsi/c/2d586494c4a0

Patch
diff mbox series

--- linux-next-20201125.orig/drivers/scsi/bnx2i/Kconfig
+++ linux-next-20201125/drivers/scsi/bnx2i/Kconfig
@@ -4,6 +4,7 @@  config SCSI_BNX2_ISCSI
 	depends on NET
 	depends on PCI
 	depends on (IPV6 || IPV6=n)
+	depends on MMU
 	select SCSI_ISCSI_ATTRS
 	select NETDEVICES
 	select ETHERNET