| Message ID | 20201201105602.465899-1-rclemsmith@gmail.com |
|---|---|
| State | New, archived |
| Delegated to: | patchwork |
| Headers | show |
| Series |
|
| Related | show |
On Tue, Dec 01, 2020 at 04:26:02PM +0530, Clement Smith wrote: > Fixed a coding style issue > > Signed-off-by: Clement Smith <rclemsmith@gmail.com> > --- > drivers/tty/serial/jsm/jsm_tty.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c index 689774c073ca..047e962a4529 100644 --- a/drivers/tty/serial/jsm/jsm_tty.c +++ b/drivers/tty/serial/jsm/jsm_tty.c @@ -607,14 +607,14 @@ void jsm_input(struct jsm_channel *ch) * Give the Linux ld the flags in the * format it likes. */ - if (*(ch->ch_equeue +tail +i) & UART_LSR_BI) - tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_BREAK); - else if (*(ch->ch_equeue +tail +i) & UART_LSR_PE) - tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_PARITY); - else if (*(ch->ch_equeue +tail +i) & UART_LSR_FE) - tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_FRAME); + if (*(ch->ch_equeue + tail + i) & UART_LSR_BI) + tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_BREAK); + else if (*(ch->ch_equeue + tail + i) & UART_LSR_PE) + tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_PARITY); + else if (*(ch->ch_equeue + tail + i) & UART_LSR_FE) + tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_FRAME); else - tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_NORMAL); + tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_NORMAL); } } else { tty_insert_flip_string(port, ch->ch_rqueue + tail, s); @@ -742,7 +742,8 @@ void jsm_check_queue_flow_control(struct jsm_channel *ch) int qleft; /* Store how much space we have left in the queue */ - if ((qleft = ch->ch_r_tail - ch->ch_r_head - 1) < 0) + qleft = ch->ch_r_tail - ch->ch_r_head - 1; + if (qleft < 0) qleft += RQUEUEMASK + 1; /*
Fixed a coding style issue Signed-off-by: Clement Smith <rclemsmith@gmail.com> --- drivers/tty/serial/jsm/jsm_tty.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)