linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: khilman@baylibre.com
Cc: robh+dt@kernel.org, narmstrong@baylibre.com,
	jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
	christianshewitt@gmail.com, jian.hu@amlogic.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	Stefan Agner <stefan@agner.ch>
Subject: [PATCH v2 5/5] arm64: dts: meson: g12b: w400: fix PHY deassert timing requirements
Date: Tue,  1 Dec 2020 14:21:41 +0100	[thread overview]
Message-ID: <a899168379ce425b35eea4a369504fd75977bd71.1606828668.git.stefan@agner.ch> (raw)
In-Reply-To: <14754fd95378b78eb9a0a3f8b6bab13f7263c7f1.1606828668.git.stefan@agner.ch>

According to the datasheet (Rev. 1.9) the RTL8211F requires at least
72ms "for internal circuits settling time" before accessing the PHY
egisters. On similar boards with the same PHY this fixes an issue where
Ethernet link would not come up when using ip link set down/up.

Fixes: 2cd2310fca4c ("arm64: dts: meson-g12b-ugoos-am6: add initial device-tree")
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
index 2802ddbb83ac..feb088504740 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
@@ -264,7 +264,7 @@ external_phy: ethernet-phy@0 {
 		max-speed = <1000>;
 
 		reset-assert-us = <10000>;
-		reset-deassert-us = <30000>;
+		reset-deassert-us = <80000>;
 		reset-gpios = <&gpio GPIOZ_15 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
 
 		interrupt-parent = <&gpio_intc>;
-- 
2.29.2


  parent reply	other threads:[~2020-12-01 13:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 13:21 [PATCH v2 1/5] arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements Stefan Agner
2020-12-01 13:21 ` [PATCH v2 2/5] arm64: dts: meson: " Stefan Agner
2020-12-05 13:14   ` Martin Blumenstingl
2020-12-01 13:21 ` [PATCH v2 3/5] ARM: " Stefan Agner
2020-12-05 13:04   ` Martin Blumenstingl
2020-12-07 17:53     ` Stefan Agner
2020-12-01 13:21 ` [PATCH v2 4/5] arm64: dts: meson: g12a: x96-max: " Stefan Agner
2020-12-05 13:14   ` Martin Blumenstingl
2020-12-01 13:21 ` Stefan Agner [this message]
2020-12-05 13:14   ` [PATCH v2 5/5] arm64: dts: meson: g12b: w400: " Martin Blumenstingl
2020-12-05 13:14 ` [PATCH v2 1/5] arm64: dts: meson: g12b: odroid-n2: " Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a899168379ce425b35eea4a369504fd75977bd71.1606828668.git.stefan@agner.ch \
    --to=stefan@agner.ch \
    --cc=christianshewitt@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jian.hu@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).