[PATCH] clk: s2mps11: Fix a resource leak in error handling paths in the probe function

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: krzk@kernel.org, b.zolnierkie@samsung.com,
	mturquette@baylibre.com, sboyd@kernel.org, yadi.brar@samsung.com,
	mturquette@linaro.org
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH] clk: s2mps11: Fix a resource leak in error handling paths in the probe function
Date: Sat, 12 Dec 2020 13:28:18 +0100	[thread overview]
Message-ID: <20201212122818.86195-1-christophe.jaillet@wanadoo.fr> (raw)

Some resource should be released in the error handling path of the probe
function, as already done in the remove function.

The remove function was fixed in commit bf416bd45738 ("clk: s2mps11: Add
missing of_node_put and of_clk_del_provider")

Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/clk/clk-s2mps11.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c
index aa21371f9104..a3e883a9f406 100644
--- a/drivers/clk/clk-s2mps11.c
+++ b/drivers/clk/clk-s2mps11.c
@@ -195,6 +195,7 @@ static int s2mps11_clk_probe(struct platform_device *pdev)
 	return ret;
 
 err_reg:
+	of_node_put(s2mps11_clks[0].clk_np);
 	while (--i >= 0)
 		clkdev_drop(s2mps11_clks[i].lookup);
 
-- 
2.27.0

