From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Ellerman <mpe@ellerman.id.au>,
x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] genirq: Reexport irq_to_desc() for PPC KVM
Date: Sun, 13 Dec 2020 14:05:15 -0000 [thread overview]
Message-ID: <160786831574.3364.1303776836725071487.tip-bot2@tip-bot2> (raw)
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 3bda84519c6c2d57e7378417ac116f61d50abae1
Gitweb: https://git.kernel.org/tip/3bda84519c6c2d57e7378417ac116f61d50abae1
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sun, 13 Dec 2020 14:33:57 +01:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sun, 13 Dec 2020 14:58:44 +01:00
genirq: Reexport irq_to_desc() for PPC KVM
Commit f07147b162a1 ("genirq: Remove export of irq_to_desc()") breaks the
PPC - CONFIG_KVM_BOOK3S_64_HV=n build because the analysis of irq_to_desc()
usage missed that the creative fiddling in arch/powerpc/kvm/ is actually in
a module and not in built in code. The only real purpose is to access
irq_desc::kstat_irqs which can be solved differently, but not without some
surgery.
Reexport it when KVM_BOOK3S_64_HV is enabled. That means that all other
modular code especially drivers/* cannot rely on it, which was the whole
point of the exercise.
Fixes: f07147b162a1 ("genirq: Remove export of irq_to_desc()")
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
---
kernel/irq/irqdesc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 5d766f4..0e1f89d 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -352,6 +352,9 @@ struct irq_desc *irq_to_desc(unsigned int irq)
{
return radix_tree_lookup(&irq_desc_tree, irq);
}
+#ifdef CONFIG_KVM_BOOK3S_64_HV
+EXPORT_SYMBOL_GPL(irq_to_desc);
+#endif
static void delete_irq_desc(unsigned int irq)
{
reply other threads:[~2020-12-13 14:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160786831574.3364.1303776836725071487.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).