[2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description
diff mbox series

Message ID 20201218103131.22013-3-martin.kepplinger@puri.sm
State Accepted
Commit c003b15b4c102f9c34f4f77978c8d9b2707d7f53
Headers show
Series
  • small Librem 5 phone dts updates
Related show

Commit Message

Martin Kepplinger Dec. 18, 2020, 10:31 a.m. UTC
Add the pinctrl description for the interrupt.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Krzysztof Kozlowski Dec. 19, 2020, 12:20 p.m. UTC | #1
On Fri, Dec 18, 2020 at 11:31:29AM +0100, Martin Kepplinger wrote:
> Add the pinctrl description for the interrupt.

Please describe why do you need to add it. From the patch contents I
easily see what you are doing. But neither the commit title nor the
message describe what you want to achieve (why are you doing it).

Best regards,
Krzysztof

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 55268fc0622e..a60df09d90f7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -459,6 +459,13 @@ 
 		>;
 	};
 
+	pinctrl_touch: touchgrp {
+		fsl,pins = <
+		/* TP_INT */
+		MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27	0x80
+		>;
+	};
+
 	pinctrl_typec: typecgrp {
 		fsl,pins = <
 			/* TYPEC_MUX_EN */
@@ -880,6 +887,8 @@ 
 	touchscreen@38 {
 		compatible = "edt,edt-ft5506";
 		reg = <0x38>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_touch>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
 		touchscreen-size-x = <720>;