[v4,4/5] arm64: dts: imx8mq: Add interconnect for lcdif
diff mbox series

Message ID 20210107121754.3295-5-martin.kepplinger@puri.sm
State New, archived
Headers show
Series
  • imx8mq: updates for the interconnect fabric
Related show

Commit Message

Martin Kepplinger Jan. 7, 2021, 12:17 p.m. UTC
Add interconnect ports for lcdif to set bus capabilities.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
 1 file changed, 3 insertions(+)

Comments

Shawn Guo Jan. 15, 2021, 9:47 a.m. UTC | #1
On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 89e7de2e7f7a..9300be8c9b53 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -11,6 +11,7 @@
>  #include "dt-bindings/input/input.h"
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/interconnect/imx8mq.h>
>  #include "imx8mq-pinfunc.h"
>  
>  / {
> @@ -522,6 +523,8 @@
>  						  <&clk IMX8MQ_VIDEO_PLL1>,
>  						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>  				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> +				interconnect-names = "dram";

Hmm, two interconnect phandles but only one name?

Shawn

>  				status = "disabled";
>  
>  				port@0 {
> -- 
> 2.20.1
>
Martin Kepplinger Jan. 15, 2021, 9:57 a.m. UTC | #2
On 15.01.21 10:47, Shawn Guo wrote:
> On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
>> Add interconnect ports for lcdif to set bus capabilities.
>>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> index 89e7de2e7f7a..9300be8c9b53 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> @@ -11,6 +11,7 @@
>>   #include "dt-bindings/input/input.h"
>>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>>   #include <dt-bindings/thermal/thermal.h>
>> +#include <dt-bindings/interconnect/imx8mq.h>
>>   #include "imx8mq-pinfunc.h"
>>   
>>   / {
>> @@ -522,6 +523,8 @@
>>   						  <&clk IMX8MQ_VIDEO_PLL1>,
>>   						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>>   				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
>> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
>> +				interconnect-names = "dram";
> 
> Hmm, two interconnect phandles but only one name?
> 

Well it's one interconnect path that would more accurately be named 
"lcdif-dram" if that's what you mean. I removed "lcdif-" because it's 
the lcdif node, but maybe we should name it lcdif-dram after all. at 
least that's how others describe it.

                               martin
Shawn Guo Jan. 15, 2021, 10:01 a.m. UTC | #3
On Fri, Jan 15, 2021 at 10:57:02AM +0100, Martin Kepplinger wrote:
> 
> 
> On 15.01.21 10:47, Shawn Guo wrote:
> > On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
> > > Add interconnect ports for lcdif to set bus capabilities.
> > > 
> > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > > ---
> > >   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
> > >   1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > index 89e7de2e7f7a..9300be8c9b53 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > @@ -11,6 +11,7 @@
> > >   #include "dt-bindings/input/input.h"
> > >   #include <dt-bindings/interrupt-controller/arm-gic.h>
> > >   #include <dt-bindings/thermal/thermal.h>
> > > +#include <dt-bindings/interconnect/imx8mq.h>
> > >   #include "imx8mq-pinfunc.h"
> > >   / {
> > > @@ -522,6 +523,8 @@
> > >   						  <&clk IMX8MQ_VIDEO_PLL1>,
> > >   						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
> > >   				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> > > +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> > > +				interconnect-names = "dram";
> > 
> > Hmm, two interconnect phandles but only one name?
> > 
> 
> Well it's one interconnect path that would more accurately be named
> "lcdif-dram" if that's what you mean. I removed "lcdif-" because it's the
> lcdif node, but maybe we should name it lcdif-dram after all. at least
> that's how others describe it.

Ha, sorry, I misunderstood the interconnects property.

Shawn
Shawn Guo Jan. 15, 2021, 10:48 a.m. UTC | #4
On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

Applied, thanks.

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 89e7de2e7f7a..9300be8c9b53 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -11,6 +11,7 @@ 
 #include "dt-bindings/input/input.h"
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/thermal/thermal.h>
+#include <dt-bindings/interconnect/imx8mq.h>
 #include "imx8mq-pinfunc.h"
 
 / {
@@ -522,6 +523,8 @@ 
 						  <&clk IMX8MQ_VIDEO_PLL1>,
 						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
 				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
+				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
+				interconnect-names = "dram";
 				status = "disabled";
 
 				port@0 {