From: Ricardo Ribalda <ribalda@chromium.org>
To: Ezequiel Garcia <ezequiel@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH] hantro: Format IOCTLs compliance fixes
Date: Mon, 11 Jan 2021 12:35:29 +0100 [thread overview]
Message-ID: <20210111113529.45488-1-ribalda@chromium.org> (raw)
Clear the reserved fields.
Fixes:
fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserved not zeroed
test VIDIOC_TRY_FMT: FAIL
fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserved not zeroed
test VIDIOC_S_FMT: FAIL
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/staging/media/hantro/hantro_v4l2.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/media/hantro/hantro_v4l2.c b/drivers/staging/media/hantro/hantro_v4l2.c
index b668a82d40ad..9b384fbffc93 100644
--- a/drivers/staging/media/hantro/hantro_v4l2.c
+++ b/drivers/staging/media/hantro/hantro_v4l2.c
@@ -239,6 +239,7 @@ static int hantro_try_fmt(const struct hantro_ctx *ctx,
const struct hantro_fmt *fmt, *vpu_fmt;
bool capture = V4L2_TYPE_IS_CAPTURE(type);
bool coded;
+ int i;
coded = capture == ctx->is_encoder;
@@ -293,6 +294,10 @@ static int hantro_try_fmt(const struct hantro_ctx *ctx,
pix_mp->width * pix_mp->height * fmt->max_depth;
}
+ for (i = 0; i < pix_mp->num_planes; i++)
+ memset(pix_mp->plane_fmt[i].reserved, 0,
+ sizeof(pix_mp->plane_fmt[i].reserved));
+
return 0;
}
--
2.30.0.284.gd98b1dd5eaa7-goog
next reply other threads:[~2021-01-11 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 11:35 Ricardo Ribalda [this message]
2021-01-11 11:48 ` [PATCH] hantro: Format IOCTLs compliance fixes Ezequiel Garcia
2021-01-11 11:55 ` Ricardo Ribalda
2021-01-11 12:22 ` Ricardo Ribalda
2021-01-11 12:24 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111113529.45488-1-ribalda@chromium.org \
--to=ribalda@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).