From: Joe Perches <joe@perches.com>
To: Christian Benvenuti <benve@cisco.com>,
Nelson Escobar <neescoba@cisco.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Greg KH <greg@kroah.com>
Subject: [PATCH] RDMA: usnic: Fix misuse of sysfs_emit_at
Date: Fri, 15 Jan 2021 13:23:59 -0800 [thread overview]
Message-ID: <f4ce30f297be4678634b5be4917401767ee6ebc5.camel@perches.com> (raw)
In commit e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show
uses to sysfs_emit") I mistakenly used len = sysfs_emit_at to overwrite
the last trailing space of potentially multiple entry output.
The length of the last sysfs_emit_at call is 1 and it should instead be
ignored. Do so.
Fixes: e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show uses to sysfs_emit")
Reported-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c b/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c
index e59615a4c9d9..fc077855b46c 100644
--- a/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c
+++ b/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c
@@ -231,7 +231,7 @@ static ssize_t summary_show(struct usnic_ib_qp_grp *qp_grp, char *buf)
}
}
- len = sysfs_emit_at(buf, len, "\n");
+ sysfs_emit_at(buf, len, "\n"); /* Overwrite the last trailing space */
return len;
}
next reply other threads:[~2021-01-15 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 21:23 Joe Perches [this message]
2021-01-15 22:15 ` [PATCH] RDMA: usnic: Fix misuse of sysfs_emit_at James Bottomley
2021-01-16 0:21 ` Joe Perches
2021-01-16 0:36 ` [PATCH V2] " Joe Perches
2021-01-20 0:32 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ce30f297be4678634b5be4917401767ee6ebc5.camel@perches.com \
--to=joe@perches.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=benve@cisco.com \
--cc=dledford@redhat.com \
--cc=greg@kroah.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=neescoba@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).