| Message ID | 20210116033259.31941-1-rdunlap@infradead.org |
|---|---|
| State | Accepted |
| Commit | 82c082784e03a9a9c043345f9bc04bc8254cf6da |
| Headers | show |
| Series |
|
| Related | show |
> From: Randy Dunlap <rdunlap@infradead.org> > Sent: Saturday, January 16, 2021 11:33 AM > Subject: [PATCH] imx: select SOC_BUS to fix firmware build Patch title probably is better to be: firmware: imx: xxxxx Otherwise: Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> Regards Aisheng > > Fix build error in firmware/imx/ selecting SOC_BUS. > > riscv32-linux-ld: drivers/firmware/imx/imx-scu-soc.o: in function `.L9': > imx-scu-soc.c:(.text+0x1b0): undefined reference to `soc_device_register' > > Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Atish Patra <atish.patra@wdc.com> > Cc: Palmer Dabbelt <palmerdabbelt@google.com> > Cc: Ard Biesheuvel <ardb@kernel.org> > Cc: Anson Huang <Anson.Huang@nxp.com> > Cc: Daniel Baluta <daniel.baluta@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Dong Aisheng <aisheng.dong@nxp.com> > --- > drivers/firmware/imx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210115.orig/drivers/firmware/imx/Kconfig > +++ linux-next-20210115/drivers/firmware/imx/Kconfig > @@ -13,6 +13,7 @@ config IMX_DSP > config IMX_SCU > bool "IMX SCU Protocol driver" > depends on IMX_MBOX > + select SOC_BUS > help > The System Controller Firmware (SCFW) is a low-level system function > which runs on a dedicated Cortex-M core to provide power, clock, and
On Mon, Jan 18, 2021 at 04:36:55AM +0000, Aisheng Dong wrote: > > From: Randy Dunlap <rdunlap@infradead.org> > > Sent: Saturday, January 16, 2021 11:33 AM > > Subject: [PATCH] imx: select SOC_BUS to fix firmware build > > Patch title probably is better to be: > firmware: imx: xxxxx Fixed it up and applied.
--- linux-next-20210115.orig/drivers/firmware/imx/Kconfig +++ linux-next-20210115/drivers/firmware/imx/Kconfig @@ -13,6 +13,7 @@ config IMX_DSP config IMX_SCU bool "IMX SCU Protocol driver" depends on IMX_MBOX + select SOC_BUS help The System Controller Firmware (SCFW) is a low-level system function which runs on a dedicated Cortex-M core to provide power, clock, and
Fix build error in firmware/imx/ selecting SOC_BUS. riscv32-linux-ld: drivers/firmware/imx/imx-scu-soc.o: in function `.L9': imx-scu-soc.c:(.text+0x1b0): undefined reference to `soc_device_register' Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Atish Patra <atish.patra@wdc.com> Cc: Palmer Dabbelt <palmerdabbelt@google.com> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: Anson Huang <Anson.Huang@nxp.com> Cc: Daniel Baluta <daniel.baluta@nxp.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/firmware/imx/Kconfig | 1 + 1 file changed, 1 insertion(+)