[v2,2/2] cgroup: update PSI file description in docs
diff mbox series

Message ID 20210116173634.1615875-3-odin@uged.al
State New, archived
Headers show
Series
  • cgroup: fix psi monitor for root cgroup
Related show

Commit Message

Odin Ugedal Jan. 16, 2021, 5:36 p.m. UTC
Update PSI file description in cgroup-v2 docs to reflect the current
implementation.

Signed-off-by: Odin Ugedal <odin@uged.al>
---
 Documentation/admin-guide/cgroup-v2.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Johannes Weiner Jan. 19, 2021, 4:56 p.m. UTC | #1
On Sat, Jan 16, 2021 at 06:36:34PM +0100, Odin Ugedal wrote:
> Update PSI file description in cgroup-v2 docs to reflect the current
> implementation.
> 
> Signed-off-by: Odin Ugedal <odin@uged.al>
> ---
>  Documentation/admin-guide/cgroup-v2.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 63521cd36ce5..f638c9d3d9f2 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1029,7 +1029,7 @@ All time durations are in microseconds.
>  	one number is written, $MAX is updated.
>  
>    cpu.pressure
> -	A read-only nested-key file which exists on non-root cgroups.
> +	A read-only nested-keyed file.

Could you please also change the 'read-only' to 'read-write'?

With that, please feel free to add:
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Tejun Heo Jan. 19, 2021, 5:03 p.m. UTC | #2
On Tue, Jan 19, 2021 at 11:56:18AM -0500, Johannes Weiner wrote:
> On Sat, Jan 16, 2021 at 06:36:34PM +0100, Odin Ugedal wrote:
> > Update PSI file description in cgroup-v2 docs to reflect the current
> > implementation.
> > 
> > Signed-off-by: Odin Ugedal <odin@uged.al>
> > ---
> >  Documentation/admin-guide/cgroup-v2.rst | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> > index 63521cd36ce5..f638c9d3d9f2 100644
> > --- a/Documentation/admin-guide/cgroup-v2.rst
> > +++ b/Documentation/admin-guide/cgroup-v2.rst
> > @@ -1029,7 +1029,7 @@ All time durations are in microseconds.
> >  	one number is written, $MAX is updated.
> >  
> >    cpu.pressure
> > -	A read-only nested-key file which exists on non-root cgroups.
> > +	A read-only nested-keyed file.
> 
> Could you please also change the 'read-only' to 'read-write'?
> 
> With that, please feel free to add:
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Applied w/ the suggested change.

Thanks.

Patch
diff mbox series

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 63521cd36ce5..f638c9d3d9f2 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1029,7 +1029,7 @@  All time durations are in microseconds.
 	one number is written, $MAX is updated.
 
   cpu.pressure
-	A read-only nested-key file which exists on non-root cgroups.
+	A read-only nested-keyed file.
 
 	Shows pressure stall information for CPU. See
 	:ref:`Documentation/accounting/psi.rst <psi>` for details.
@@ -1475,7 +1475,7 @@  PAGE_SIZE multiple when read back.
 	reduces the impact on the workload and memory management.
 
   memory.pressure
-	A read-only nested-key file which exists on non-root cgroups.
+	A read-only nested-keyed file.
 
 	Shows pressure stall information for memory. See
 	:ref:`Documentation/accounting/psi.rst <psi>` for details.
@@ -1714,7 +1714,7 @@  IO Interface Files
 	  8:16 rbps=2097152 wbps=max riops=max wiops=max
 
   io.pressure
-	A read-only nested-key file which exists on non-root cgroups.
+	A read-only nested-keyed file.
 
 	Shows pressure stall information for IO. See
 	:ref:`Documentation/accounting/psi.rst <psi>` for details.