block: Fix an error handling in add_partition
diff mbox series

Message ID 20210117085023.24352-1-dinghao.liu@zju.edu.cn
State Accepted
Commit ef49d40b61a3e18a11edd5eb1c30b0183af9e850
Headers show
Series
  • block: Fix an error handling in add_partition
Related show

Commit Message

Dinghao Liu Jan. 17, 2021, 8:50 a.m. UTC
Once we have called device_initialize(), we should use put_device() to
give up the reference on error, just like what we have done on failure
of device_add().

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---

Changelog:

v2: - Refine commit message.
---
 block/partitions/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Jan. 20, 2021, 10:05 a.m. UTC | #1
On Sun, Jan 17, 2021 at 04:50:17PM +0800, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Jens Axboe Jan. 25, 2021, 4:36 a.m. UTC | #2
On 1/17/21 1:50 AM, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().

Applied for 5.11, thanks.

Patch
diff mbox series

diff --git a/block/partitions/core.c b/block/partitions/core.c
index e7d776db803b..23460cee9de5 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -384,7 +384,7 @@  static struct block_device *add_partition(struct gendisk *disk, int partno,
 
 	err = blk_alloc_devt(bdev, &devt);
 	if (err)
-		goto out_bdput;
+		goto out_put;
 	pdev->devt = devt;
 
 	/* delay uevent until 'holders' subdir is created */