From: peng.fan@nxp.com
To: ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, o.rempel@pengutronix.de,
robh+dt@kernel.org, devicetree@vger.kernel.org
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, paul@crapouillou.net,
matthias.bgg@gmail.com, agross@kernel.org,
patrice.chotard@st.com, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V9 05/10] remoteproc: imx_rproc: correct err message
Date: Thu, 21 Jan 2021 09:03:30 +0800 [thread overview]
Message-ID: <1611191015-22584-6-git-send-email-peng.fan@nxp.com> (raw)
In-Reply-To: <1611191015-22584-1-git-send-email-peng.fan@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
It is using devm_ioremap, so not devm_ioremap_resource. Correct
the error message and print out sa/size.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/remoteproc/imx_rproc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 6603e00bb6f4..2a093cea4997 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
att->sa, att->size);
if (!priv->mem[b].cpu_addr) {
- dev_err(dev, "devm_ioremap_resource failed\n");
+ dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa);
return -ENOMEM;
}
priv->mem[b].sys_addr = att->sa;
@@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
if (IS_ERR(priv->mem[b].cpu_addr)) {
- dev_err(dev, "devm_ioremap_resource failed\n");
+ dev_err(dev, "failed to remap %pr\n", &res);
err = PTR_ERR(priv->mem[b].cpu_addr);
return err;
}
--
2.28.0
next prev parent reply other threads:[~2021-01-21 1:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 1:03 [PATCH V9 00/10] remoteproc: imx_rproc: support iMX8MQ/M peng.fan
2021-01-21 1:03 ` [PATCH V9 01/10] dt-bindings: remoteproc: convert imx rproc bindings to json-schema peng.fan
2021-01-26 13:49 ` Peng Fan
2021-02-05 20:27 ` Rob Herring
2021-01-21 1:03 ` [PATCH V9 02/10] dt-bindings: remoteproc: imx_rproc: add i.MX8MQ/M support peng.fan
2021-01-21 1:03 ` [PATCH V9 03/10] remoteproc: introduce is_iomem to rproc_mem_entry peng.fan
2021-01-21 1:03 ` [PATCH V9 04/10] remoteproc: add is_iomem to da_to_va peng.fan
2021-01-21 1:03 ` peng.fan [this message]
2021-01-21 1:03 ` [PATCH V9 06/10] remoteproc: imx_rproc: use devm_ioremap peng.fan
2021-01-21 1:03 ` [PATCH V9 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook peng.fan
2021-01-21 1:03 ` [PATCH V9 08/10] remoteproc: imx_rproc: support i.MX8MQ/M peng.fan
2021-01-21 1:03 ` [PATCH V9 09/10] remoteproc: imx_rproc: ignore mapping vdev regions peng.fan
2021-01-21 1:03 ` [PATCH V9 10/10] remoteproc: imx_proc: enable virtio/mailbox peng.fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611191015-22584-6-git-send-email-peng.fan@nxp.com \
--to=peng.fan@nxp.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).