From: Coiby Xu <coiby.xu@gmail.com>
To: devel@driverdev.osuosl.org
Cc: Benjamin Poirier <benjamin.poirier@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Shung-Hsi Yu <shung-hsi.yu@suse.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
GR-Linux-NIC-Dev@marvell.com, Manish Chopra <manishc@marvell.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org (open list:QLOGIC QLGE 10Gb ETHERNET
DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v4 5/8] staging: qlge: support force_coredump option for devlink health dump
Date: Sat, 23 Jan 2021 18:46:10 +0800 [thread overview]
Message-ID: <20210123104613.38359-6-coiby.xu@gmail.com> (raw)
In-Reply-To: <20210123104613.38359-1-coiby.xu@gmail.com>
With force_coredump module parameter set, devlink health dump will
reset the MPI RISC first which takes 5 secs to be finished.
Note that only NIC function that owns the firmware can do the
force_dumping. Otherwise devlink will receive an EPERM error.
Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
drivers/staging/qlge/qlge_devlink.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/qlge/qlge_devlink.c b/drivers/staging/qlge/qlge_devlink.c
index bf7d75ed5eae..c6ef5163e241 100644
--- a/drivers/staging/qlge/qlge_devlink.c
+++ b/drivers/staging/qlge/qlge_devlink.c
@@ -56,10 +56,23 @@ static int qlge_reporter_coredump(struct devlink_health_reporter *reporter,
struct qlge_adapter *qdev = devlink_health_reporter_priv(reporter);
struct qlge_mpi_coredump *dump;
+ wait_queue_head_t wait;
if (!netif_running(qdev->ndev))
return 0;
+ if (test_bit(QL_FRC_COREDUMP, &qdev->flags)) {
+ if (qlge_own_firmware(qdev)) {
+ qlge_queue_fw_error(qdev);
+ init_waitqueue_head(&wait);
+ wait_event_timeout(wait, 0, 5 * HZ);
+ } else {
+ netif_err(qdev, ifup, qdev->ndev,
+ "Force Coredump failed because this NIC function doesn't own the firmware\n");
+ return -EPERM;
+ }
+ }
+
dump = kvmalloc(sizeof(*dump), GFP_KERNEL);
if (!dump)
return -ENOMEM;
--
2.29.2
next prev parent reply other threads:[~2021-01-23 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210123104613.38359-1-coiby.xu@gmail.com>
2021-01-23 10:46 ` [PATCH v4 1/8] staging: qlge: use qlge_* prefix to avoid namespace clashes with other qlogic drivers Coiby Xu
2021-01-23 10:46 ` [PATCH v4 2/8] staging: qlge: Initialize devlink health dump framework Coiby Xu
2021-01-23 10:46 ` [PATCH v4 3/8] staging: qlge: re-write qlge_init_device Coiby Xu
2021-01-23 10:46 ` [PATCH v4 4/8] staging: qlge: coredump via devlink health reporter Coiby Xu
2021-01-23 10:46 ` Coiby Xu [this message]
2021-01-23 10:46 ` [PATCH v4 6/8] staging: qlge: remove mpi_core_to_log which sends coredump to the kernel ring buffer Coiby Xu
2021-01-23 10:46 ` [PATCH v4 7/8] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land Coiby Xu
2021-01-23 10:46 ` [PATCH v4 8/8] staging: qlge: add documentation for debugging qlge Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123104613.38359-6-coiby.xu@gmail.com \
--to=coiby.xu@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=benjamin.poirier@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=shung-hsi.yu@suse.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).