From: Paul Cercueil <paul@crapouillou.net>
To: Bin Liu <b-liu@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tony Lindgren <tony@atomide.com>,
od@zcrc.me, linux-mips@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>,
Maarten ter Huurne <maarten@treewalker.org>
Subject: [RE-RESEND PATCH 2/4] usb: musb: Fix NULL check on struct musb_request field
Date: Sat, 23 Jan 2021 14:25:00 +0000 [thread overview]
Message-ID: <20210123142502.16980-2-paul@crapouillou.net> (raw)
In-Reply-To: <20210123142502.16980-1-paul@crapouillou.net>
The 'request' variable is a pointer to the 'request' field of the
struct musb_request 'req' pointer. It only worked until now because
the 'request' field is the first one in the musb_request structure, but
as soon as that changes, the check will be invalid.
Fix it preventively by doing the NULL-check on the 'req' pointer
instead.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Suggested-by: Maarten ter Huurne <maarten@treewalker.org>
Acked-by: Tony Lindgren <tony@atomide.com>
---
drivers/usb/musb/musb_gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index f62ffaede1ab..ef374d4dd94a 100644
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -451,7 +451,7 @@ void musb_g_tx(struct musb *musb, u8 epnum)
return;
}
- if (request) {
+ if (req) {
trace_musb_req_tx(req);
--
2.29.2
next prev parent reply other threads:[~2021-01-23 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 14:24 [RE-RESEND PATCH 1/4] usb: musb: Fix runtime PM race in musb_queue_resume_work Paul Cercueil
2021-01-23 14:25 ` Paul Cercueil [this message]
2021-01-23 14:25 ` [RE-RESEND PATCH 3/4] usb: musb: dma: Remove unused variable Paul Cercueil
2021-01-23 14:25 ` [RE-RESEND PATCH 4/4] usb: musb: jz4740: Add missing CR to error strings Paul Cercueil
2021-01-23 16:41 ` [RE-RESEND PATCH 1/4] usb: musb: Fix runtime PM race in musb_queue_resume_work Sergei Shtylyov
2021-01-24 8:38 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123142502.16980-2-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maarten@treewalker.org \
--cc=od@zcrc.me \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).